Pipeline error source

[Deepp0925]

Fixes: #34842

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes (not needed)
• tests and/or benchmarks are included (not needed)
• documentation is changed or added
• commit message follows commit guidelines

added a property index to error object in the pipeline function to that point towards the error causing stream

[himself65]

I would not like this PR, If you want to debug which pipeline crashed, you could add debug log in this module, instead of adding this unnecessary fields.

like

node/lib/_http_common.js

Lines 42 to 44 in 22e3ada

	let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
	debug = fn;
	});

node/lib/_http_client.js

Line 521 in 22e3ada

debug('parse error', ret);

[aduh95]

Function.prototype.bind doesn't modify the original finish function, so that line has no effect as is. You would need to do something like:

const finishWithIndex = finish.bind({ index: i });

// ... and below, change occurrences of `finish` in the function scope
destroys.push(destroyer(ret, false, true, finishWithIndex));

Not a very elegant variable name, I'm very bad at naming those things 😅

[rickyes]

ping @nodejs/streams

[ronag]

Tests are failing.

Not sure I see the need for this? You can just attach an 'error' handler to each stream you pass into pipeline?

[rickyes]

I would not like this PR, If you want to debug which pipeline crashed, you could add debug log in this module, instead of adding this unnecessary fields.

like

node/lib/_http_common.js

Lines 42 to 44 in 22e3ada

	let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
	debug = fn;
	});

node/lib/_http_client.js

Line 521 in 22e3ada

debug('parse error', ret);

Not debugging, I think what makes sense is that you can make a corresponding downgrade strategy based on which stream is in error.

[ronag]

Closing this as stale.