Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: align source-map stacks with spec #37252

Closed
wants to merge 1 commit into from

Conversation

@bcoe
Copy link
Member

@bcoe bcoe commented Feb 6, 2021

Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks


After discussion with @ljharb, who's working on the Error Stacks TC39 spec, we decided that it would be better to modify the behavior of --enable-source-maps, so that the user gets just the original call site, rather than both the original and transpiled call site.

The reasoning being, this gives us much of the value of the --enable-source-maps feature, without deviating from stack traces on other platforms.

This is a step towards removing the experimental flag from --enable-source-maps.

CC: @nodejs/tooling

Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks
@bcoe bcoe requested review from devsnek, aduh95 and joyeecheung Feb 6, 2021
Copy link
Member

@ljharb ljharb left a comment

LGTM, thanks!

Trott
Trott approved these changes Feb 6, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Feb 6, 2021

iansu
iansu approved these changes Feb 7, 2021
devsnek
devsnek approved these changes Feb 7, 2021
bcoe added a commit that referenced this issue Feb 12, 2021
Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks

PR-URL: #37252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@bcoe
Copy link
Member Author

@bcoe bcoe commented Feb 12, 2021

Landed in 88d9268

@bcoe bcoe closed this Feb 12, 2021
danielleadams added a commit that referenced this issue Feb 16, 2021
Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks

PR-URL: #37252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
targos added a commit that referenced this issue May 27, 2021
Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks

PR-URL: #37252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this issue May 30, 2021
Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks

PR-URL: #37252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks

PR-URL: #37252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this issue Jun 6, 2021
Notable changes:

deps:
  * update ICU to 69.1 (Michaël Zasso) #38178
src:
  * align source-map stacks with spec (Benjamin Coe) #37252

PR-URL: #38948
targos added a commit that referenced this issue Jun 11, 2021
Reformat stack traces when --enable-source-maps flag is set to format
more likely to fit https://github.com/tc39/proposal-error-stacks

PR-URL: #37252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
Notable changes:

deps:
  * update ICU to 69.1 (Michaël Zasso) #38178
src:
  * align source-map stacks with spec (Benjamin Coe) #37252

PR-URL: #38948
targos added a commit that referenced this issue Jun 14, 2021
Notable changes:

deps:
  * update ICU to 69.1 (Michaël Zasso) #38178
src:
  * align source-map stacks with spec (Benjamin Coe) #37252

PR-URL: #38948
targos added a commit that referenced this issue Jun 15, 2021
Notable changes:

deps:
  * update ICU to 69.1 (Michaël Zasso) #38178
src:
  * align source-map stacks with spec (Benjamin Coe) #37252

PR-URL: #38948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants