Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-doctool-html #37397

Merged
merged 1 commit into from Feb 16, 2021
Merged

test: fix test-doctool-html #37397

merged 1 commit into from Feb 16, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 16, 2021 •
edited

Refs: #37301

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Feb 16, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 16, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 16, 2021

fast-track?

Trott
Trott approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mild preference for @danielleadams's suggestion for balancing the opening/closing tags in the result fragment, but fine either way.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 mentioned this pull request Feb 16, 2021
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36156/

@aduh95
test: fix test-doctool-html
1c6484b 
Refs: nodejs#37301

PR-URL: nodejs#37397
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 16, 2021

Landed in 1c6484b

@aduh95 aduh95 merged commit 1c6484b into nodejs:master Feb 16, 2021
@aduh95 aduh95 deleted the doctool-fix-tests branch February 16, 2021 17:53
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@aduh95 @danielleadams
test: fix test-doctool-html
b5692b4 
Refs: #37301

PR-URL: #37397
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
test: fix test-doctool-html
8386b88 
Refs: #37301

PR-URL: #37397
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@Trott Trott Trott approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aduh95 @nodejs-github-bot @Trott @danielleadams @RaisinTen