Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: check version number in YAML comments from changelogs #37599

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 4, 2021

@aduh95 aduh95 added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 4, 2021
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 4, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2021
@aduh95 aduh95 force-pushed the lint-version-from-changelogs branch from a5dbc78 to a49d403 Compare March 5, 2021 11:05
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
PR-URL: nodejs#37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the lint-version-from-changelogs branch from a49d403 to 8de1e19 Compare March 6, 2021 17:47
@aduh95 aduh95 merged commit 8de1e19 into nodejs:master Mar 6, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 6, 2021

Landed in 8de1e19

@aduh95 aduh95 deleted the lint-version-from-changelogs branch March 6, 2021 17:48
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented May 1, 2021

marked dont-land-on LTS branches because we don't backport changelog updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants