Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] doc: mark modules implementation as stable #37718

Merged
merged 1 commit into from Mar 17, 2021

Conversation

MylesBorins
Copy link
Member

We had kept the implementation as experimental to leave room for large changes that might land prior to 16. With the Semver-Major cut-off looming I don't think we'll be seeing any. Let's mark ESM stable and make it clear that folks can use this in prod

PR-URL: #35781
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Myles Borins myles.borins@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Derek Lewis DerekNonGeneric@inf.is

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v12.x labels Mar 11, 2021
@MylesBorins
Copy link
Member Author

/cc @nodejs/modules

PR-URL: nodejs#35781
Backport-PR-URL: nodejs#37718
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@richardlau
Copy link
Member

Landed in bf8733f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants