Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty: validate file descriptor to avoid int32 overflow #37809

Merged
merged 1 commit into from
Mar 23, 2021
Merged

tty: validate file descriptor to avoid int32 overflow #37809

merged 1 commit into from
Mar 23, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 19, 2021

Fixes: #37805

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem. labels Mar 19, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36810/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36821/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36863/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36873/

@aduh95
tty: validate file descriptor to avoid int32 overflow
134fb5a 
Fixes: nodejs#37805

PR-URL: nodejs#37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 23, 2021

Landed in 134fb5a

@aduh95 aduh95 merged commit 134fb5a into nodejs:master Mar 23, 2021
@aduh95 aduh95 deleted the tty-isatty-int32 branch March 23, 2021 10:03
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@aduh95 @ruyadorno
tty: validate file descriptor to avoid int32 overflow
3452618 
Fixes: #37805

PR-URL: #37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
tty: validate file descriptor to avoid int32 overflow
d89d55a 
Fixes: #37805

PR-URL: #37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"tty.isatty" results in an abort
6 participants
@aduh95 @nodejs-github-bot @jasnell @lpinca @BridgeAR @RaisinTen