Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc #42852

Merged
merged 1 commit into from
May 4, 2022
Merged

src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc #42852

merged 1 commit into from
May 4, 2022

Conversation

RaisinTen
Copy link
Contributor

Refs: #39941
Signed-off-by: Darshan Sen raisinten@gmail.com

@RaisinTen
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
62e211d 
Refs: nodejs#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 24, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 25, 2022
Open
16 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Apr 26, 2022
Open
Open
Open
Open
@RaisinTen RaisinTen requested review from jasnell and addaleax May 2, 2022 04:21
@RaisinTen
Copy link
Contributor Author

@addaleax PTAL.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43877/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7ff2170 into nodejs:master May 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7ff2170

@RaisinTen RaisinTen deleted the src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc branch May 5, 2022 04:41
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@RaisinTen @RafaelGSS
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
8cfc18e 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@RaisinTen @juanarbol
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
70c4f39 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@RaisinTen @danielleadams
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
afae7d3 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jul 12, 2022
@RaisinTen @targos
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
4617a35 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RaisinTen @targos
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
1a98f16 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RaisinTen @guangwong
src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
3fda6aa 
Refs: nodejs/node#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaisinTen @nodejs-github-bot @addaleax @tniessen