tools: remove Babel from license-builder.sh #41049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license.
nodejs-github-bot
added
meta
targos
approved these changes
Dec 1, 2021
aduh95
approved these changes
Dec 1, 2021
lpinca
approved these changes
Dec 1, 2021
tniessen
approved these changes
Dec 2, 2021
jasnell
approved these changes
Dec 2, 2021
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 14d9c38 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: #41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: #41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: #41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: #41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: nodejs#41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Babel is now installed as a dependency in our ESLint installation. The current license-builder.sh will fail to find the license for Babel. The license is sill present in the repository/code base/file system. So as with all other dependencies that are installed in tools/node_modules/eslint/node_modules and have an MIT license, we are still complying with the license. The inclusion in our own LICENSE was to clearly signal that things under tools/node_modules/@babel were not covered by the Node.js license. Because it is now under tools/node_modules/eslint, that "we aren't the license-holders of this code" aspect of things is already covered by the inclusion of the ESLint license. PR-URL: #41049 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel is now installed as a dependency in our ESLint installation. The
current license-builder.sh will fail to find the license for Babel.
The license is sill present in the repository/code base/file system. So
as with all other dependencies that are installed in
tools/node_modules/eslint/node_modules and have an MIT license, we are
still complying with the license. The inclusion in our own LICENSE was
to clearly signal that things under tools/node_modules/@babel were not
covered by the Node.js license. Because it is now under
tools/node_modules/eslint, that "we aren't the license-holders of this
code" aspect of things is already covered by the inclusion of the ESLint
license.