doc: add v16 changelog link to iojs changelog #41808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Feb 1, 2022
aduh95
approved these changes
Feb 1, 2022
aduh95
added
author ready
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Mesteery
approved these changes
Feb 1, 2022
cjihrig
approved these changes
Feb 1, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/41808 ✔ Done loading data for nodejs/node/pull/41808 ----------------------------------- PR info ------------------------------------ Title doc: add v16 changelog link to iojs changelog (#41808) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch danielleadams:da/add-missing-changelog-to-iojs -> nodejs:master Labels doc, fast-track, author ready, release Commits 1 - doc: add v16 changelog link to iojs changelog Committers 1 - Danielle Adams PR-URL: https://github.com/nodejs/node/pull/41808 Reviewed-By: Richard Lau Reviewed-By: Antoine du Hamel Reviewed-By: Mestery Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41808 Reviewed-By: Richard Lau Reviewed-By: Antoine du Hamel Reviewed-By: Mestery Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Feb 2022 13:21:36 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41808#pullrequestreview-869129863 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41808#pullrequestreview-869131523 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41808#pullrequestreview-869147766 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41808#pullrequestreview-869151975 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1778699719 |
nodejs-github-bot
added
the
commit-queue-failed
BethGriggs
approved these changes
Feb 1, 2022
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7904331 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41808 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams
added a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41808 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams
added a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41808 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams
added a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41808 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing v16 Changelog link to the old iojs Changelog.