-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add mailmap entry for ShogunPanda #43094
Conversation
.mailmap
Outdated
Paolo Insogna <paolo@cowtech.it> <paolo.insogna@nearform.com> | ||
Paolo Insogna <paolo@cowtech.it> <shogun@cowtech.it> | ||
Paolo Insogna <paolo@cowtech.it> <ShogunPanda@users.noreply.github.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines aren't needed unless you plan to commit from those email addresses in the future.
Paolo Insogna <paolo@cowtech.it> <paolo.insogna@nearform.com> | |
Paolo Insogna <paolo@cowtech.it> <shogun@cowtech.it> | |
Paolo Insogna <paolo@cowtech.it> <ShogunPanda@users.noreply.github.com> |
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
Commit Queue failed- Loading data for nodejs/node/pull/43094 ✔ Done loading data for nodejs/node/pull/43094 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for ShogunPanda (#43094) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:mailmap -> nodejs:master Labels meta, fast-track Commits 2 - meta: add mailmap entry for ShogunPanda - meta: respect alphabetical order Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 14 May 2022 05:51:43 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43094#pullrequestreview-973087994 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43094#pullrequestreview-973092919 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2325051169 |
Commit Queue failed- Loading data for nodejs/node/pull/43094 ✔ Done loading data for nodejs/node/pull/43094 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for ShogunPanda (#43094) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:mailmap -> nodejs:master Labels meta, fast-track, commit-queue-squash Commits 2 - meta: add mailmap entry for ShogunPanda - meta: respect alphabetical order Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 14 May 2022 05:51:43 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43094#pullrequestreview-973087994 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43094#pullrequestreview-973092919 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2325080361 |
Not sure why the Windows stuff is failing in GitHub CI, but I rebased and force-pushed in case the fix is on the master branch. |
Landed in 8a5657b |
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs/node#43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
See: #43036 (comment)