test_runner: wait for stderr and stdout to complete #43666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoLow
force-pushed
the
test-runner-attempt-fixing-flaky-test
branch
from
2536e4f
to
7ef9c56
Compare
MoLow
changed the title
MoLow
changed the title
MoLow
changed the title
MoLow
force-pushed
the
test-runner-attempt-fixing-flaky-test
branch
from
7ef9c56
to
97b5953
Compare
VoltrexKeyva
added
the
test_runner
benjamingr
approved these changes
Jul 4, 2022
github-actions
bot
removed
the
request-ci
MoLow
force-pushed
the
test-runner-attempt-fixing-flaky-test
branch
from
97b5953
to
b82a40f
Compare
aduh95
reviewed
Jul 4, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Jul 5, 2022
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
16 tasks
benjamingr
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43666 ✔ Done loading data for nodejs/node/pull/43666 ----------------------------------- PR info ------------------------------------ Title test_runner: wait for stderr and stdout to complete (#43666) Author Moshe Atlow (@MoLow) Branch MoLow:test-runner-attempt-fixing-flaky-test -> nodejs:main Labels needs-ci, test_runner Commits 2 - test_runner: wait for stderr and stdout to complete - Apply suggestions from code review Committers 2 - Moshe Atlow - GitHub PR-URL: https://github.com/nodejs/node/pull/43666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 03 Jul 2022 09:59:50 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/43666#pullrequestreview-1027872861 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43666#pullrequestreview-1028257215 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-08T07:51:08Z: https://ci.nodejs.org/job/node-test-pull-request/45150/ - Querying data for job/node-test-pull-request/45150/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43666 From https://github.com/nodejs/node * branch refs/pull/43666/merge -> FETCH_HEAD ✔ Fetched commits as f3a92a0572b1..e48d3eccbd6c -------------------------------------------------------------------------------- [main 83c342419f] test_runner: wait for stderr and stdout to complete Author: Moshe Atlow Date: Sun Jul 3 12:57:29 2022 +0300 1 file changed, 4 insertions(+), 1 deletion(-) [main 96fffa486f] Apply suggestions from code review Author: Moshe Atlow Date: Mon Jul 4 23:45:19 2022 +0300 1 file changed, 2 insertions(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/2635335874 |
benjamingr
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e1ab9dc |
|
Thanks you @MoLow |
Sure. I hope this will fix the issue |
21 tasks
aduh95
pushed a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 9, 2022
PR-URL: nodejs/node#43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 9, 2022
PR-URL: nodejs/node#43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an attempt to fix #43618