Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder #44104

Merged
merged 1 commit into from
Aug 4, 2022
Merged

bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder #44104

merged 1 commit into from
Aug 4, 2022

Conversation

joyeecheung
Copy link
Member

To improve startup performance.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45806/

@Hilljackcantspell

This comment was marked as off-topic.

Sign in to view
@legendecas legendecas mentioned this pull request Aug 3, 2022
Merged
@F3n67u F3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3970c7a into nodejs:main Aug 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3970c7a

joyeecheung added a commit to joyeecheung/node that referenced this pull request Aug 5, 2022
@joyeecheung
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
c8a81f5 
To improve startup performance.

PR-URL: nodejs#44104
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@joyeecheung @danielleadams
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
bd27b8b 
To improve startup performance.

PR-URL: #44104
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@joyeecheung @ruyadorno
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
123b2d6 
To improve startup performance.

PR-URL: #44104
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@joyeecheung @Fyko
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
d58db7d 
To improve startup performance.

PR-URL: nodejs#44104
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@joyeecheung @nodejs-github-bot @Hilljackcantspell @addaleax @legendecas @targos @F3n67u @aduh95