bootstrap: fixup Error.stackTraceLimit for user-land snapshot #44203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult for V8 to handle Error.stackTraceLimit in the snapshot, so delete it from the Error constructor if it's present before snapshot serialization, and re-install it after deserialization. In addition try not to touch it from our internals during snapshot building in the first place by updating isErrorStackTraceLimitWritable().
nodejs-github-bot
added
errors
|
After looking into https://chromium-review.googlesource.com/c/v8/v8/+/3319481 I think that it makes more sense for us to clean it up - there are several constraints in the SnapshotCreator that don't exist from the embedder's side so it's just much simpler to handle this in Node.js. It should be a rare case that only shows up when users actually try to mutate Error.stackTraceLimit themselves in the snapshot script anyway. |
aduh95
reviewed
Aug 11, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
legendecas
reviewed
Aug 11, 2022
aduh95
reviewed
Aug 17, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Aug 17, 2022
8 tasks
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4f1a9fc |
This was referenced Aug 19, 2022
This was referenced Aug 21, 2022
ruyadorno
added
the
backport-blocked-v18.x
This comment was marked as resolved.
This comment was marked as resolved.
ruyadorno
removed
the
backport-blocked-v18.x
|
I managed to land #38905 and retried this one which did land cleanly this time, as such I'm removing the |
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
It's difficult for V8 to handle Error.stackTraceLimit in the snapshot, so delete it from the Error constructor if it's present before snapshot serialization, and re-install it after deserialization. In addition try not to touch it from our internals during snapshot building in the first place by updating isErrorStackTraceLimitWritable(). PR-URL: #44203 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
It's difficult for V8 to handle Error.stackTraceLimit in the snapshot, so delete it from the Error constructor if it's present before snapshot serialization, and re-install it after deserialization. In addition try not to touch it from our internals during snapshot building in the first place by updating isErrorStackTraceLimitWritable(). PR-URL: nodejs#44203 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Looks like this depends on #38905; the v16.x branch is presenting some issues w/ this PR; I will mark this as the presumptuous dependency. Feel free to remove the label if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult for V8 to handle Error.stackTraceLimit in the snapshot,
so delete it from the Error constructor if it's present before
snapshot serialization, and re-install it after deserialization.
In addition try not to touch it from our internals during snapshot
building in the first place by updating
isErrorStackTraceLimitWritable().