-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve assertions in test-repl-unsupported-option.js
#44953
test: improve assertions in test-repl-unsupported-option.js
#44953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I noticed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the CI is happy.
Commit Queue failed- Loading data for nodejs/node/pull/44953 ✔ Done loading data for nodejs/node/pull/44953 ----------------------------------- PR info ------------------------------------ Title test: improve assertions in `test-repl-unsupported-option.js` (#44953) Author Juan José (@juanarbol) Branch juanarbol:juan/endurance-asserts-repl-test -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: improve assertions in `test-repl-unsupported-option.js` Committers 1 - Juan José Arboleda PR-URL: https://github.com/nodejs/node/pull/44953 Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung Reviewed-By: Kohei Ueno Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44953 Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung Reviewed-By: Kohei Ueno Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 10 Oct 2022 19:31:20 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44953#pullrequestreview-1136460634 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/44953#pullrequestreview-1136738208 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138243493 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138244930 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138255796 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-10-11T22:59:31Z: https://ci.nodejs.org/job/node-test-pull-request/47199/ - Querying data for job/node-test-pull-request/47199/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3252094696 |
Landed in 73dc825 |
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
No description provided.