-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: print failed JS/parallel tests #45960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huzzah!
/Cc @nodejs/testing |
Can you add a test failure in this PR, and run a light CI to see it impacts it negatively? |
Another tiny tweak that I think would make a huge improvement would be to add an empty line and/or horizontal line between test outputs (as it currently is, they are back to back, each block is nigh indistinguishable from the next). |
fa7ce89
to
5254d06
Compare
5254d06
to
a645ef6
Compare
I just tried it and I think two blank lines are ideal, because many of the tests have single blank lines within them (like after a stack trace, say) but rarely if ever two blank lines, so visually scanning down a lot of results the two blank lines help make the breaks stand out. |
This is a CI run with an intentionally failing test: https://ci.nodejs.org/job/node-test-pull-request/48725/ |
@cclauss I’ve added the type hint and responded to all of your suggestions. I believe this resolves your concerns; do you mind please removing your block? |
@cclauss Please let me know if you have any other notes. |
Commit Queue failed- Loading data for nodejs/node/pull/45960 ✔ Done loading data for nodejs/node/pull/45960 ----------------------------------- PR info ------------------------------------ Title test: print failed JS/parallel tests (#45960) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:print-failures -> nodejs:main Labels test, tools, python, author ready, commit-queue-squash Commits 5 - test: print failed JS/parallel tests - add type hint - Add newline between failed test outputs - Match style for variable names - Add import for backward compatibility Committers 1 - Geoffrey Booth PR-URL: https://github.com/nodejs/node/pull/45960 Reviewed-By: Jacob Smith Reviewed-By: Christian Clauss ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45960 Reviewed-By: Jacob Smith Reviewed-By: Christian Clauss -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 24 Dec 2022 01:50:48 GMT ✔ Approvals: 2 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/45960#pullrequestreview-1229549661 ✔ - Christian Clauss (@cclauss): https://github.com/nodejs/node/pull/45960#pullrequestreview-1230212097 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3783385909 |
Landed in eb4c83f |
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
This is a small productivity improvement. When running
make test
, or specificallymake test-parallel
ormake jstest
, if there any failed JavaScript (or parallel-run) tests, the error output is printed but the only summary is a line like this:With this PR, in addition to the previous output the test runner will also print a list of the failed tests, like so:
Again, this is in addition to the current output; the present full output for each test is preserved.
My reasons for adding this:
cc @nodejs/testing @nodejs/test_runner @nodejs/python