New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: remove --no-experimental-global-webcrypto
flag
#46079
Conversation
Review requested:
|
@aduh95 what is the semverness of this change? We've only made the webcrypto api global (and stable) by default in 19.x onward. Also, should |
3f0ed98
to
d8edf03
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should rush it, unless having the flag is blocking something else.
Yes, as it simplifies the job of embedders such as Electron that expose browser globals from another runtime such as Chromium. It's being taken care of by Lines 226 to 231 in 4310522
|
This comment was marked as outdated.
This comment was marked as outdated.
6c4fffa
to
c72ce95
Compare
This comment was marked as outdated.
This comment was marked as outdated.
It's probably just blocking the TODO so that pre_execution could get cleaned up. If that's not a pressing issue I propose we alias the flag as WDYT? |
I think we need to keep the flag as experimental and get rid of it in the near future, if we remove the experimental part of it, we would have to go through a full deprecation cycle. While the WebCrypto implementation itself is robust, and deserves to be called stable, the I would do that for 21.x or 22.x, so in case the current implementation breaks someone's code, they have a full LTS cycle to adapt and can use the flag to unblock them in the mean time. |
Very well. I did not think of the CLI flag itself as experimental. I'll revisit this before 21 or 22. |
Removes the
--no-experimental-global-webcrypto
flag and moves the global definitions tointernal/bootstrap/browser
.