-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readline: fix detection of carriage return #46306
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:readline-carriage-return
Jan 24, 2023
Merged
readline: fix detection of carriage return #46306
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:readline-carriage-return
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jan 22, 2023
jasnell
approved these changes
Jan 22, 2023
BridgeAR
approved these changes
Jan 22, 2023
lpinca
approved these changes
Jan 22, 2023
aymen94
approved these changes
Jan 22, 2023
anonrig
approved these changes
Jan 23, 2023
Landed in e8d4015 |
Thank you! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
readline
Issues and PRs related to the built-in readline module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #45992