-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: remove targets for individual test suites in Makefile
#46892
Conversation
Makefile
Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've doubled checked and AFAICT nothing in our CI is using any of the removed targets. To err on the safe side, I've added "dont-land-` labels in case any downstream consumers/repackagers are using these targets in their scripts.
cc @nodejs/distros |
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug | ||
|
||
.PHONY: test-message | ||
test-message: test-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This target and the ones below that are being removed are also present in vcbuild.bat. Might be worth removing these from there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure we remove the same things in the vcbuild.bat file too. (Once that's done, feel free to dismiss this review. No need to wait for me to do it.)
Landed in 553b052 |
I find those target not very useful (instead of typing
make test-message
, it's as easy to typetools/test.py test/message
IMO), and sometimes their name is confusing (e.g. sometimes folks would confusemake test-parallel
for running the tests in parallel, while in fact it's running – sequentially by default – thetest/parallel
test suite).wdyt?