Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove targets for individual test suites in Makefile #46892

Merged
merged 2 commits into from
Mar 31, 2023
Merged

tools: remove targets for individual test suites in Makefile #46892

merged 2 commits into from
Mar 31, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 1, 2023

I find those target not very useful (instead of typing make test-message, it's as easy to type tools/test.py test/message IMO), and sometimes their name is confusing (e.g. sometimes folks would confuse make test-parallel for running the tests in parallel, while in fact it's running – sequentially by default – the test/parallel test suite).
wdyt?

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 1, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50139/

@richardlau richardlau changed the title tolls: remove targets for individual test suites in Makefile tools: remove targets for individual test suites in Makefile Mar 1, 2023
@richardlau richardlau added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Mar 1, 2023
richardlau
richardlau approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've doubled checked and AFAICT nothing in our CI is using any of the removed targets. To err on the safe side, I've added "dont-land-` labels in case any downstream consumers/repackagers are using these targets in their scripts.

@aduh95 aduh95 added dont-land-on-v19.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 1, 2023
@richardlau
Copy link
Member

I've doubled checked and AFAICT nothing in our CI is using any of the removed targets. To err on the safe side, I've added "dont-land-` labels in case any downstream consumers/repackagers are using these targets in their scripts.

cc @nodejs/distros

RaisinTen
RaisinTen approved these changes Mar 2, 2023
View reviewed changes
Makefile
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug

.PHONY: test-message
test-message: test-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target and the ones below that are being removed are also present in vcbuild.bat. Might be worth removing these from there too?

Trott
Trott requested changes Mar 2, 2023
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we remove the same things in the vcbuild.bat file too. (Once that's done, feel free to dismiss this review. No need to wait for me to do it.)

@aduh95 aduh95 requested a review from Trott March 18, 2023 11:13
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50674/

This was referenced Mar 30, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50740/

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 553b052 into nodejs:main Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 553b052

@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Open
38 tasks
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aduh95 @nodejs-github-bot @richardlau @jasnell @Trott @RaisinTen