src: support V8 experimental shared values in messaging #47706

syg · 2023-04-24T19:05:11Z

This adds the missing integration support for the V8 experimental shared structs feature (--harmony-struct). There is no observable difference to node if --harmony-struct is not passed. The flag is false by default.

This experimental feature is for proving out shared memory in JS. The standards side is tracked by https://github.com/tc39/proposal-structs, though the current experiment, for the sake of ease of experimentation, does not include syntax. The features in experiment is documented here.

I also intentionally did not add any tests because the features are experimental and volatile. Here is an illustrative example though:

'use strict';
const { Worker, isMainThread, parentPort } = require('worker_threads');

if (isMainThread) {
  let Box = new SharedStructType(['payload']);
  let b = new Box();
  b.payload = "hello shared memory world";

  let worker = new Worker(__filename);
  worker.on('message', (message) => {
    console.log(b.payload);
    console.log(message === b);
  });

  worker.postMessage(b);
} else {
  parentPort.on('message', (message) => {
    // Simple echo.
    parentPort.postMessage(message);
  });
}

syg · 2023-04-24T19:05:56Z

cc @rbuckton, I had meant to do this a while back but totally forgot. Once this merges then TSC can start playing around with the dev trial as well.

debadree25 · 2023-04-25T09:22:48Z

cc @nodejs/workers

nodejs-github-bot · 2023-04-25T22:41:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51470/

syg · 2023-04-26T00:07:21Z

@joyeecheung I don't know nodejs very well. Is the CI saying this PR is causing some test failures? I find that rather surprising.

nodejs-github-bot · 2023-04-26T04:54:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51471/

nodejs-github-bot · 2023-04-26T06:02:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51472/

joyeecheung · 2023-04-26T17:52:57Z

I don't know nodejs very well. Is the CI saying this PR is causing some test failures? I find that rather surprising.

The test failures were probably just unmarked flakes. https://ci.nodejs.org/job/node-test-pull-request/51472/ passed (with marked flakes).

addaleax

I think adding a test would be valuable unless you are really certain that somebody will remember to add one once the feature's no longer experimental :)

syg · 2023-04-27T22:17:05Z

I think adding a test would be valuable unless you are really certain that somebody will remember to add one once the feature's no longer experimental :)

Reasonable request, though I still prefer to not add a node test. The dev trial API surface is under enough flux that when I change things on the V8 side for the sake of experimentation I don't want to be blocked on breaking nodejs tests on the V8 infra. Whatever test we add now will be highly likely to be invalid once the feature is no longer experimental anyway, because the experimental dev trial doesn't use syntax to declare shared structs.

~~OTOH I'm all for adding "examples" that aren't run on the CI and block them but can be run by hand. WDYT?~~

Edit: I added a test.

nodejs-github-bot · 2023-05-03T15:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51606/

nodejs-github-bot · 2023-05-04T14:29:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51628/

syg · 2023-05-05T20:25:25Z

@joyeecheung I still don't know how to read the CI reports. :) Does this look good to land?

test/parallel/test-experimental-shared-value-conveyor.js

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot · 2023-05-08T00:04:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51693/

syg · 2023-05-08T15:37:28Z

Good to merge?

nodejs-github-bot · 2023-05-08T16:44:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51702/

joyeecheung · 2023-05-08T16:45:18Z

Need to re-run the CI until it's green

nodejs-github-bot · 2023-05-09T06:38:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/47706 ✔ Done loading data for nodejs/node/pull/47706 ----------------------------------- PR info ------------------------------------ Title src: support V8 experimental shared values in messaging (#47706) Author Shu-yu Guo (@syg) Branch syg:shared-value-conveyor -> nodejs:main Labels c++, worker, needs-ci Commits 5 - src: support V8 experimental shared values in messaging - Add a test - Fix linter errors - Update test/parallel/test-experimental-shared-value-conveyor.js - Quell linter Committers 2 - Shu-yu Guo - GitHub PR-URL: https://github.com/nodejs/node/pull/47706 Reviewed-By: Joyee Cheung Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47706 Reviewed-By: Joyee Cheung Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 24 Apr 2023 19:05:11 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47706#pullrequestreview-1415757197 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/47706#pullrequestreview-1404880614 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-08T16:44:58Z: https://ci.nodejs.org/job/node-test-pull-request/51702/ - Querying data for job/node-test-pull-request/51702/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47706 From https://github.com/nodejs/node * branch refs/pull/47706/merge -> FETCH_HEAD ✔ Fetched commits as 0b3fcfcf351f..a0946e915825 -------------------------------------------------------------------------------- Auto-merging src/node_messaging.cc [main e400a95a4e] src: support V8 experimental shared values in messaging Author: Shu-yu Guo Date: Mon Apr 24 11:15:07 2023 -0700 2 files changed, 31 insertions(+), 4 deletions(-) [main 620a4f5057] Add a test Author: Shu-yu Guo Date: Tue May 2 13:49:57 2023 -0700 1 file changed, 23 insertions(+) create mode 100644 test/parallel/test-experimental-shared-value-conveyor.js [main 806c2bce27] Fix linter errors Author: Shu-yu Guo Date: Tue May 2 14:14:40 2023 -0700 1 file changed, 2 insertions(+), 2 deletions(-) [main d4b2962cae] Update test/parallel/test-experimental-shared-value-conveyor.js Author: Shu-yu Guo Date: Fri May 5 17:09:16 2023 -0400 1 file changed, 3 insertions(+), 1 deletion(-) [main 641c3af3b9] Quell linter Author: Shu-yu Guo Date: Fri May 5 15:05:18 2023 -0700 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: support V8 experimental shared values in messaging

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

[detached HEAD 6a7fbf90f2] src: support V8 experimental shared values in messaging
Author: Shu-yu Guo syg@chromium.org
Date: Mon Apr 24 11:15:07 2023 -0700
2 files changed, 31 insertions(+), 4 deletions(-)
Rebasing (3/10)
Rebasing (4/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Add a test

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

[detached HEAD 80840620cd] Add a test
Author: Shu-yu Guo syg@chromium.org
Date: Tue May 2 13:49:57 2023 -0700
1 file changed, 23 insertions(+)
create mode 100644 test/parallel/test-experimental-shared-value-conveyor.js
Rebasing (5/10)
Rebasing (6/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Fix linter errors

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

[detached HEAD 5e3d362c49] Fix linter errors
Author: Shu-yu Guo syg@chromium.org
Date: Tue May 2 14:14:40 2023 -0700
1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (7/10)
Rebasing (8/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update test/parallel/test-experimental-shared-value-conveyor.js

Co-authored-by: Joyee Cheung joyeec9h3@gmail.com
PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

[detached HEAD f884cd13a6] Update test/parallel/test-experimental-shared-value-conveyor.js
Author: Shu-yu Guo syg@chromium.org
Date: Fri May 5 17:09:16 2023 -0400
1 file changed, 3 insertions(+), 1 deletion(-)
Rebasing (9/10)
Rebasing (10/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Quell linter

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

[detached HEAD 2ad3799a03] Quell linter
Author: Shu-yu Guo syg@chromium.org
Date: Fri May 5 15:05:18 2023 -0700
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4923112701

nodejs-github-bot · 2023-05-09T06:46:41Z

Landed in b2f6eed

PR-URL: #47706 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

src: support V8 experimental shared values in messaging

cee0ba8

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 24, 2023

debadree25 added the worker Issues and PRs related to Worker support. label Apr 25, 2023

joyeecheung approved these changes Apr 25, 2023

View reviewed changes

github-actions bot mentioned this pull request Apr 26, 2023

CI Reliability 2023-04-26 nodejs/reliability#547

Open

36 tasks

github-actions bot mentioned this pull request Apr 27, 2023

CI Reliability 2023-04-27 nodejs/reliability#548

Open

35 tasks

addaleax approved these changes Apr 27, 2023

View reviewed changes

syg added 2 commits May 2, 2023 13:49

Add a test

f02aad9

Fix linter errors

edfb5d8

github-actions bot mentioned this pull request May 4, 2023

CI Reliability 2023-05-04 nodejs/reliability#555

Open

28 tasks

github-actions bot mentioned this pull request May 5, 2023

CI Reliability 2023-05-05 nodejs/reliability#556

Open

22 tasks

joyeecheung reviewed May 5, 2023

View reviewed changes

test/parallel/test-experimental-shared-value-conveyor.js Outdated Show resolved Hide resolved

Update test/parallel/test-experimental-shared-value-conveyor.js

eeaf843

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

github-actions bot mentioned this pull request May 8, 2023

CI Reliability 2023-05-08 nodejs/reliability#559

Open

26 tasks

github-actions bot mentioned this pull request May 9, 2023

CI Reliability 2023-05-09 nodejs/reliability#560

Open

29 tasks

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 9, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023

nodejs-github-bot merged commit b2f6eed into nodejs:main May 9, 2023

This was referenced May 10, 2023

CI Reliability 2023-05-10 nodejs/reliability#561

Open

CI Reliability 2023-05-11 nodejs/reliability#562

Open

CI Reliability 2023-05-12 nodejs/reliability#563

Open

targos pushed a commit that referenced this pull request May 12, 2023

src: support V8 experimental shared values in messaging

4293cc4

PR-URL: #47706 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced May 13, 2023

CI Reliability 2023-05-13 nodejs/reliability#564

Open

CI Reliability 2023-05-14 nodejs/reliability#565

Open

targos mentioned this pull request May 15, 2023

v20.2.0 release proposal #48020

Merged

danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: support V8 experimental shared values in messaging #47706

src: support V8 experimental shared values in messaging #47706

syg commented Apr 24, 2023 •

edited

Loading

syg commented Apr 24, 2023

debadree25 commented Apr 25, 2023

nodejs-github-bot commented Apr 25, 2023

syg commented Apr 26, 2023

nodejs-github-bot commented Apr 26, 2023

nodejs-github-bot commented Apr 26, 2023

joyeecheung commented Apr 26, 2023 •

edited

Loading

addaleax left a comment

syg commented Apr 27, 2023 •

edited

Loading

nodejs-github-bot commented May 3, 2023

nodejs-github-bot commented May 4, 2023

syg commented May 5, 2023

nodejs-github-bot commented May 8, 2023

syg commented May 8, 2023

nodejs-github-bot commented May 8, 2023

joyeecheung commented May 8, 2023

nodejs-github-bot commented May 9, 2023

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

Co-authored-by: Joyee Cheung joyeec9h3@gmail.com
PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented May 9, 2023

src: support V8 experimental shared values in messaging #47706

src: support V8 experimental shared values in messaging #47706

Conversation

syg commented Apr 24, 2023 • edited Loading

syg commented Apr 24, 2023

debadree25 commented Apr 25, 2023

nodejs-github-bot commented Apr 25, 2023

syg commented Apr 26, 2023

nodejs-github-bot commented Apr 26, 2023

nodejs-github-bot commented Apr 26, 2023

joyeecheung commented Apr 26, 2023 • edited Loading

addaleax left a comment

Choose a reason for hiding this comment

syg commented Apr 27, 2023 • edited Loading

nodejs-github-bot commented May 3, 2023

nodejs-github-bot commented May 4, 2023

syg commented May 5, 2023

nodejs-github-bot commented May 8, 2023

syg commented May 8, 2023

nodejs-github-bot commented May 8, 2023

joyeecheung commented May 8, 2023

nodejs-github-bot commented May 9, 2023

PR-URL: #47706 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net

Co-authored-by: Joyee Cheung joyeec9h3@gmail.com PR-URL: #47706 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented May 9, 2023

syg commented Apr 24, 2023 •

edited

Loading

joyeecheung commented Apr 26, 2023 •

edited

Loading

syg commented Apr 27, 2023 •

edited

Loading

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

Co-authored-by: Joyee Cheung joyeec9h3@gmail.com
PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #47706
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net