Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: warn on detection in typeless package #52168

Merged
merged 1 commit into from
Mar 23, 2024
Merged

module: warn on detection in typeless package #52168

merged 1 commit into from
Mar 23, 2024

Conversation

GeoffreyBooth
Copy link
Member

Following up on #52093 (comment), this PR prints a warning when a .js file runs as ESM due to detection, if that file is within the scope of a package.json file that lacks a type field. In discussion with @joyeecheung we decided to warn once per applicable package.json file, so that the warning corresponds with a straightforward remediation.

@GeoffreyBooth GeoffreyBooth added module Issues and PRs related to the module subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. labels Mar 21, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 21, 2024
mcollina
mcollina approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@H4ad H4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57871/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57900/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2024
@GeoffreyBooth GeoffreyBooth added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit f4a0a3b into nodejs:main Mar 23, 2024
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f4a0a3b

@GeoffreyBooth GeoffreyBooth deleted the detect-module-warning branch March 23, 2024 01:42
anonrig pushed a commit to anonrig/node that referenced this pull request Mar 25, 2024
@GeoffreyBooth @anonrig
module: warn on detection in typeless package
b4ca669 
PR-URL: nodejs#52168
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@GeoffreyBooth @rdw-msft
module: warn on detection in typeless package
6c1307f 
PR-URL: nodejs#52168
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 16, 2024
Closed
@marco-ippolito marco-ippolito added backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@H4ad H4ad H4ad approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@GeoffreyBooth @nodejs-github-bot @mcollina @joyeecheung @H4ad @aduh95 @marco-ippolito