Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 12.3 #52293

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 12.3 #52293

wants to merge 13 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 31, 2024

No description provided.

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Mar 31, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 31, 2024
@targos
Copy link
Member Author

targos commented Mar 31, 2024

@StefanStojanovic b9d806a from the 12.2 update doesn't land cleanly (it has many conflicts).

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member Author

targos commented Mar 31, 2024

@RafaelGSS There UBSan build fails:

2024-03-31T14:31:31.1917522Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’:
2024-03-31T14:31:31.1937899Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.1950274Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.1962978Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >; size_t = long unsigned int]’
2024-03-31T14:31:31.1977270Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = v8::internal::compiler::turboshaft::MemoryAddress; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.1986665Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2004874Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::iterator, bool>]’
2024-03-31T14:31:31.2037304Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; K = v8::internal::compiler::turboshaft::MemoryAddress; V = v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::iterator, bool>]’
2024-03-31T14:31:31.2073473Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::EmplaceDecomposable; Ts = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; P = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::iterator, bool>]’
2024-03-31T14:31:31.2102279Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.2122406Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >]’
2024-03-31T14:31:31.2133095Z ../deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.h:504:32:   required from here
2024-03-31T14:31:31.2138164Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, void>::get_hash_slot_fn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress> >()’
2024-03-31T14:31:31.2144834Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::compiler::turboshaft::MemoryAddress> == 0)’ is not a constant expression
2024-03-31T14:31:31.2147730Z   163 |     return Policy::template get_hash_slot_fn<Hash>() == nullptr
2024-03-31T14:31:31.2148621Z       |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
2024-03-31T14:31:31.2154720Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’:
2024-03-31T14:31:31.2165104Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2174907Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2185274Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >; size_t = long unsigned int]’
2024-03-31T14:31:31.2195928Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = v8::internal::compiler::turboshaft::OpIndex; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2202487Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2216631Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::iterator, bool>]’
2024-03-31T14:31:31.2239550Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; K = v8::internal::compiler::turboshaft::OpIndex; V = v8::internal::compiler::turboshaft::BaseData; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::iterator, bool>]’
2024-03-31T14:31:31.2264386Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::EmplaceDecomposable; Ts = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; P = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::iterator, bool>]’
2024-03-31T14:31:31.2284584Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2299095Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>]’
2024-03-31T14:31:31.2306549Z ../deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.h:579:48:   required from here
2024-03-31T14:31:31.2310580Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, void>::get_hash_slot_fn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex> >()’
2024-03-31T14:31:31.2315652Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::compiler::turboshaft::OpIndex> == 0)’ is not a constant expression
2024-03-31T14:31:31.2324709Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’:
2024-03-31T14:31:31.2338318Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2351915Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2365270Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >; size_t = long unsigned int]’
2024-03-31T14:31:31.2378167Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = int; Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2385762Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2404210Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::EmplaceDecomposable; Args = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::iterator, bool>]’
2024-03-31T14:31:31.2437252Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::EmplaceDecomposable; Args = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; K = int; V = v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits>; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::iterator, bool>]’
2024-03-31T14:31:31.2472769Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::EmplaceDecomposable; Ts = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; P = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::iterator, bool>]’
2024-03-31T14:31:31.2502483Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2523046Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >]’
2024-03-31T14:31:31.2533836Z ../deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.h:594:54:   required from here
2024-03-31T14:31:31.2539203Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, void>::get_hash_slot_fn<absl::hash_internal::Hash<int> >()’
2024-03-31T14:31:31.2544943Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<int>, int> == 0)’ is not a constant expression
2024-03-31T14:31:31.2552586Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’:
2024-03-31T14:31:31.2563199Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2574015Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2584913Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >; size_t = long unsigned int]’
2024-03-31T14:31:31.2596192Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = v8::internal::compiler::turboshaft::OpIndex; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2603633Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2618514Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::iterator, bool>]’
2024-03-31T14:31:31.2644404Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; K = v8::internal::compiler::turboshaft::OpIndex; V = v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::iterator, bool>]’
2024-03-31T14:31:31.2671570Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::EmplaceDecomposable; Ts = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; P = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::iterator, bool>]’
2024-03-31T14:31:31.2694131Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2709727Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>]’
2024-03-31T14:31:31.2717967Z ../deps/v8/src/compiler/turboshaft/pretenuring-propagation-reducer.h:183:44:   required from here
2024-03-31T14:31:31.2722479Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, void>::get_hash_slot_fn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex> >()’
2024-03-31T14:31:31.2728380Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::compiler::turboshaft::OpIndex> == 0)’ is not a constant expression
2024-03-31T14:31:35.8286012Z make[2]: *** [tools/v8_gypfiles/v8_turboshaft.target.mk:224: /home/runner/work/node/node/out/Release/obj.target/v8_turboshaft/deps/v8/src/compiler/turboshaft/csa-optimize-phase.o] Error 1
2024-03-31T14:31:35.8287188Z make[2]: *** Waiting for unfinished jobs....
2024-03-31T14:32:17.7245954Z rm 9ac559b3661ef3e3ae7143f36ccc6691e578b31c.intermediate 2ad06b2c9baade6b27c5c82cdcc7af11c369378d.intermediate 02a486ff0aa87df511c38b125409357fdc559df2.intermediate
2024-03-31T14:32:17.7255924Z make[1]: *** [Makefile:134: node] Error 2
2024-03-31T14:32:17.7258403Z make: *** [Makefile:581: build-ci] Error 2
2024-03-31T14:32:17.7273528Z ##[error]Process completed with exit code 2.

@RafaelGSS
Copy link
Member

Can we include those files in the suppressions list?

@targos
Copy link
Member Author

targos commented Apr 1, 2024

Can you help me do it? I'm not familiar with ubsan and I don't know what to add to the suppressions list.

@StefanStojanovic
Copy link
Contributor

@StefanStojanovic b9d806a from the 12.2 update doesn't land cleanly (it has many conflicts).

As expected. I'll update the patch. Thanks for letting me know.

@targos
Copy link
Member Author

targos commented Apr 5, 2024

Can you help me do it? I'm not familiar with ubsan and I don't know what to add to the suppressions list.

I suspect it's unrelated to ubsan. I opened #52375 to use a more recent Ubuntu.

@targos
Copy link
Member Author

targos commented Apr 8, 2024

@RafaelGSS IIUC, it may be related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962. I still don't really know what to do about it.
Latest V8 canary builds include #52375 and fail with the same error.

@RafaelGSS
Copy link
Member

@RafaelGSS IIUC, it may be related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962. I still don't really know what to do about it. Latest V8 canary builds include #52375 and fail with the same error.

I will take a look as soon as I finish the security release

@targos
Copy link
Member Author

targos commented Apr 10, 2024

@StefanStojanovic do you have an ETA for the Windows fix? v22.0.0 is dangerously close.

@nodejs-github-bot
Copy link
Collaborator

@StefanStojanovic
Copy link
Contributor

@StefanStojanovic do you have an ETA for the Windows fix? v22.0.0 is dangerously close.

@targos I was able to get it to compile yesterday. I am still not sure if I broke something in the process and will need to run tests. Also, I'm trying to see if I can decrease the number of changes from the last time (I was already able to drop some). When will the v22 be locked for the official RC?

@targos
Copy link
Member Author

targos commented Apr 11, 2024

When will the v22 be locked for the official RC?

I don't know but I suppose some day next week. I was hoping to also try and update to 12.4 before it, that's why I'm a bit scared of timing.

@targos
Copy link
Member Author

targos commented Apr 11, 2024

Actually, I'll open a parallel PR for 12.4 right away. If the only issue is the Windows patch, we may skip this one.

@StefanStojanovic
Copy link
Contributor

That sounds good, I decreased the number of files affected by the patch, so now there is at least some chance, although a small one if I'm being honest, to simply apply v12.3 patch on v12.4.

@targos targos mentioned this pull request Apr 11, 2024
@targos
Copy link
Member Author

targos commented Apr 11, 2024

12.4 PR: #52465

@StefanStojanovic
Copy link
Contributor

@targos here is how things stand with this. I have a branch (will tidy it up once I am about to open a PR). I ran it through CI. Here is the list of the runs (each was a Resume build from the previous):

In the first two builds I had some tests fail. They were behaving like flaky tests as they failed in only one configuration in each build, but passed in all others. The test that failed in both is test-error-serdes, which I didn't see flaking before.

On another note I tried applying patches on v12.4 and saw only 3-4 files had issues. So it should not be too hard to try and apply it on v12.4, although I cannot guarantee it will compile without further changes. I'll work on that tomorrow and update you on the other PR with what I've got.

marco-ippolito pushed a commit that referenced this pull request Apr 19, 2024
Original commit message:

    Fix build with gcc12

    - A number of erroneous flags have been added to BUILD.gn
    - wasm-init-expr.cc is creating an 8 byte buffer witch may be
      much smaller than max size_t output. We also need to make room
      for the `f` character and the terminating null character
    - inspector_protocol currently generates the following error
       ```
       error: loop variable ‘json_in’ of type ‘const std::string&’ {aka
       ‘const std::__cxx11::basic_string<char>&’} binds to a temporary
       constructed from type ‘const char* const’
       ```

    Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#92615}

Refs: v8/v8@c4be0a9
PR-URL: #52183
Refs: v8/v8@f8d5e57
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit that referenced this pull request Apr 19, 2024
Original commit message:

    [compiler] reset script details in functions deserialized from code cache

    During the serialization of the code cache, V8 would wipe out the
    host-defined options, so after a script id deserialized from the
    code cache, the host-defined options need to be reset on the script
    using what's provided by the embedder when doing the deserializing
    compilation, otherwise the HostImportModuleDynamically callbacks
    can't get the data it needs to implement dynamic import().

    Change-Id: I33cc6a5e43b6469d3527242e083f7ae6d8ed0c6a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5401780
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#93323}

Refs: v8/v8@cd10ad7
PR-URL: #52535
Refs: #47472
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito added a commit that referenced this pull request Apr 19, 2024
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 20, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 21, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 22, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS added a commit that referenced this pull request Apr 22, 2024
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>
targos added a commit to targos/node that referenced this pull request Apr 23, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Apr 23, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 23, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito added a commit that referenced this pull request Apr 23, 2024
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>
targos added a commit that referenced this pull request Apr 24, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 24, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS added a commit that referenced this pull request Apr 24, 2024
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 26, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 27, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Apr 27, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 27, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 28, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Apr 28, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 28, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 29, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 30, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 1, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 2, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 3, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 4, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants