build: temporary disable ubsan #52560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
RafaelGSS
force-pushed
the
temporary-remove-ubsan
branch
from
7aaa253
to
93badab
Compare
RafaelGSS
changed the title
aduh95
reviewed
Apr 16, 2024
aduh95
approved these changes
Apr 16, 2024
richardlau
approved these changes
Apr 16, 2024
RafaelGSS
force-pushed
the
temporary-remove-ubsan
branch
from
93badab
to
ec583f9
Compare
RafaelGSS
added
author ready
MoLow
approved these changes
Apr 17, 2024
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52560 ✔ Done loading data for nodejs/node/pull/52560 ----------------------------------- PR info ------------------------------------ Title build: temporary disable ubsan (#52560) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:temporary-remove-ubsan -> nodejs:main Labels meta, fast-track, author ready Commits 1 - build: temporary disable ubsan Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52560 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52560 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 16 Apr 2024 22:02:22 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/52560#pullrequestreview-2004735272 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/52560#pullrequestreview-2004742323 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52560#pullrequestreview-2005014402 ℹ This PR is being fast-tracked ✘ This PR needs to wait 41 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8716525349 |
targos
approved these changes
Apr 17, 2024
marco-ippolito
approved these changes
Apr 17, 2024
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 139624c |
RafaelGSS
added a commit
that referenced
this pull request
Apr 22, 2024
PR-URL: #52560 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52560 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52560 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #52293 (comment)