module: skip NODE_COMPILE_CACHE when policy is enabled #52577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be worth designing a policy for the compilation cache. For now, just skip the cache when policy is enabled.
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
|
huh there isn't a team for policy, it seems, so cc @nodejs/startup @nodejs/loaders @nodejs/security |
legendecas
reviewed
Apr 18, 2024
| @@ -1096,6 +1096,12 @@ void Environment::InitializeCompileCache() { | |||
| dir_from_env.empty()) { | |||
| return; | |||
| } | |||
| if (!options()->experimental_policy.empty()) { | |||
| Debug(this, | |||
There was a problem hiding this comment.
Could this be a warning instead?
There was a problem hiding this comment.
The environment variable is designed to be as silent as possible. I don't think there's anything to warn - you don't get a speed up and that is all, your code will still work as intended. If you are using policy it's likely that you are already aware this is already leading to a slowdown for every module loaded due to all the checks required.
benjamingr
approved these changes
Apr 18, 2024
richardlau
approved these changes
Apr 18, 2024
github-actions
bot
removed
the
request-ci
|
Updated the test to skip in no crypto builds because policy requires crypto to work. |
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Apr 22, 2024
joyeecheung
added
the
commit-queue
joyeecheung
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2231be6 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
It might be worth designing a policy for the compilation cache. For now, just skip the cache when policy is enabled. PR-URL: #52577 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be worth designing a policy for the compilation cache. For now, just skip the cache when policy is enabled.