Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove incorrect entry from changelog #546

Merged
merged 1 commit into from
Jan 22, 2015
Merged

Conversation

piscisaureus
Copy link
Contributor

@piscisaureus
Copy link
Contributor Author

Proudly made with the github™ editor

@bnoordhuis
Copy link
Member

You should remove the R=@bnoordhuis from the commit log and maybe mention the revert commit.

@piscisaureus
Copy link
Contributor Author

Dang! now I still don't get to use the merge button.

`url.format()` doesn't take a `path` option; the change that
introduced it was reverted in 913addb.

PR: #546
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
@piscisaureus piscisaureus merged commit 60402b9 into v1.x Jan 22, 2015
@piscisaureus piscisaureus deleted the piscisaureus-patch-1 branch January 22, 2015 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants