New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: remove deprecated process.EventEmitter #6862

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@cjihrig
Contributor

cjihrig commented May 18, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

process.EventEmitter was deprecated for v6. This commit removes it for v7.

Refs: #5049

process: remove deprecated process.EventEmitter
process.EventEmitter was deprecated for v6. This commit removes
it for v7.
@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented May 18, 2016

LGTM!

@addaleax

This comment has been minimized.

Member

addaleax commented May 18, 2016

@jasnell

This comment has been minimized.

Member

jasnell commented May 18, 2016

LGTM

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented May 18, 2016

Aren't we supposed to leave it for an LTS cycle? -1?

@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented May 18, 2016

I think we can consider that condition fulfilled: it was deprecated almost five years ago.

@cjihrig

This comment has been minimized.

Contributor

cjihrig commented May 18, 2016

Where is that policy exactly? It might be a matter of interpretation, as it wouldn't show up in LTS until Node v8.

cjihrig added a commit that referenced this pull request May 24, 2016

process: remove deprecated process.EventEmitter
process.EventEmitter was deprecated for v6. This commit removes
it for v7.

Refs: #5049
PR-URL: #6862
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig

This comment has been minimized.

Contributor

cjihrig commented May 24, 2016

Landed in 62b5442.

@cjihrig cjihrig closed this May 24, 2016

@cjihrig cjihrig deleted the cjihrig:rm-ee branch May 24, 2016

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment