tools: add compile_commands.json gyp generator #7986

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
3 participants
@bnoordhuis
Member

bnoordhuis commented Aug 5, 2016

Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

No need to merge right away. I'm opening the PR in case people find it useful.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 5, 2016

Member

Rubber stamp LGTM (seems like a good thing but I haven't given it a thorough review)

Member

jasnell commented Aug 5, 2016

Rubber stamp LGTM (seems like a good thing but I haven't given it a thorough review)

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jan 6, 2017

Member

Ping.. @bnoordhuis do you still want to do this?

Member

jasnell commented Jan 6, 2017

Ping.. @bnoordhuis do you still want to do this?

@jasnell jasnell added the stalled label Jan 6, 2017

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 7, 2017

Member

I guess I'll go ahead and land this. Rebased and CI for good measure: https://ci.nodejs.org/job/node-test-pull-request/6258/

Member

bnoordhuis commented Feb 7, 2017

I guess I'll go ahead and land this. Rebased and CI for good measure: https://ci.nodejs.org/job/node-test-pull-request/6258/

@bnoordhuis bnoordhuis removed the stalled label Feb 7, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: #7986
Reviewed-By: James M Snell <jasnell@gmail.com>

@bnoordhuis bnoordhuis closed this Feb 9, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:compile_commands_json branch Feb 9, 2017

@bnoordhuis bnoordhuis merged commit 3c46bb9 into nodejs:master Feb 9, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: #7986
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: nodejs#7986
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: nodejs#7986
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: #7986
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: #7986
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: #7986
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

tools: add compile_commands.json gyp generator
Add a compile_commands.json generator for use with clang-based tooling.

Pass the (undocumented) -C switch to configure to make it generate the
files in out/Debug and out/Release.

PR-URL: #7986
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

refack added a commit that referenced this pull request Apr 18, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

evanlucas added a commit that referenced this pull request Apr 25, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

evanlucas added a commit that referenced this pull request May 1, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

evanlucas added a commit that referenced this pull request May 2, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request May 16, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 12, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 18, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Jul 18, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 9, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

@springmeyer springmeyer referenced this pull request in mapbox/node-cpp-skel Aug 17, 2017

Closed

Build clang-tidy support into node-cpp-skel #63

refack added a commit to refack/node that referenced this pull request Aug 19, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 23, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

MylesBorins added a commit that referenced this pull request Sep 12, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment