Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
inspector: listen on process.debugPort #8386
Affected core subsystem(s)
Description of change
This commit consolidates the debugging port used by the inspector and Node's legacy debugger. This eliminates any chance of the two debuggers working side by side, but the inspector is currently an unofficial feature, and the legacy debugger should eventually be removed in favor of it.
1 similar comment
Final CI came back OK: https://ci.nodejs.org/job/node-test-pull-request/4040/
Sep 14, 2016
9 checks passed
Was this it?
Given that you can set the port manually, wouldn't debuggers have to be able to determine which protocol was being used with 100% certainty?
The issue is that some debuggers support both the old protocol and new, and when a user requests that the debugger attach to a running process at port 5858, the debugger has no way of knowing with protocol to use. I think this was originally requested by the VSCode folks, but I can't seem to find the discussion (/cc @joshgav, @nojvek).