guides: add guides from the core repo #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds 4 guides from the nodejs/node repo to the guides section of the website. The documentation working group would like to make these guides more visible for end users. Ref: nodejs/node#10792
1 task
gibfahn
approved these changes
Jan 19, 2017
hiroppy
approved these changes
Jan 19, 2017
thefourtheye
approved these changes
Jan 19, 2017
Qard
approved these changes
Jan 19, 2017
jasnell
approved these changes
Jan 19, 2017
|
I'll land tomorrow if no one has objections. Thanks! |
evanlucas
added a commit
to evanlucas/node
that referenced
this pull request
Jan 24, 2017
This commit removes the topics and guides that the documentation working group has proposed added to the website. We want them to have more visibility and believe that moving them to the website does that. Ref: nodejs/nodejs.org#1105 Fixes: nodejs#10792 PR-URL: nodejs#10896 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
This commit removes the topics and guides that the documentation working group has proposed added to the website. We want them to have more visibility and believe that moving them to the website does that. Ref: nodejs/nodejs.org#1105 Fixes: nodejs#10792 PR-URL: nodejs#10896 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
This commit removes the topics and guides that the documentation working group has proposed added to the website. We want them to have more visibility and believe that moving them to the website does that. Ref: nodejs/nodejs.org#1105 Fixes: nodejs#10792 PR-URL: nodejs#10896 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 4 guides from the nodejs/node repo to the guides section of
the website. The documentation working group would like to make these
guides more visible for end users.
Ref: nodejs/node#10792
Note: these guides have been copied from https://github.com/nodejs/node/tree/master/doc/topics with slight modification to fit the format of the website. The changes made are as follows:
consoleortxtlanguages in code blocksWe are still trying to determine the place to make these most visible, but has decided to go ahead and
get them moved to this repo and determine the accessibility portion at a later date.
/cc @nodejs/documentation