Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proper color for a:hover code #170

Merged
merged 1 commit into from
Sep 18, 2015
Merged

Conversation

bogas04
Copy link
Contributor

@bogas04 bogas04 commented Sep 17, 2015

Fix for #168

screen shot 2015-09-17 at 10 38 51 pm
becomes
screen shot 2015-09-17 at 10 40 31 pm

@@ -30,6 +30,8 @@ a:active
a:hover
color #fff
background-color $node-green
code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little nit picking, but separating the ordinary a:hover styling from the code element style improves readability IMO.

ATM this results in a stylus parser error as you forgot to add color before the hex below 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad ! Achievement Unlocked, mess-up simple CSS fix

@bogas04
Copy link
Contributor Author

bogas04 commented Sep 18, 2015

@phillipj I guess I can't mess it up anymore 🙈 let's merge it

fhemberger added a commit that referenced this pull request Sep 18, 2015
add proper color for a:hover code
@fhemberger fhemberger merged commit c3adbbe into nodejs:master Sep 18, 2015
@fhemberger
Copy link
Contributor

Thanks!

@bogas04 bogas04 deleted the issue168 branch September 18, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants