Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-ca: Sync site.json with english version #1837

Merged
merged 4 commits into from
Oct 22, 2018

Conversation

Tsuna-mi
Copy link
Contributor

This PR update locale/ca/site.json file as its english version.
To review it we need some help from native catalan speakers. Thanks!

(cc @kvhuaxa @franher @axarrafols @jose-lara)
Related with #1778

This PR update locale/ca/site.json file as its english version.
To review it we need some help from native catalan speakers. Thanks!
(cc @kvhuaxa @franher @axarrafols)
Related with #1778
@Tsuna-mi Tsuna-mi added the i18n Issues/PRs related to the Website Internationalisation label Oct 13, 2018
@@ -71,11 +71,13 @@
},
"package-manager": {
"link": "download/package-manager",
"text": "instal·lar Node.js amb gestor de paquets"
"text": "instal·lar Node.js mitjançant gestor de paquets"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start with capital I: Instal·lar...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mitjançant un gestor de paquets could be more accurate

Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -71,11 +71,13 @@
},
"package-manager": {
"link": "download/package-manager",
"text": "instal·lar Node.js amb gestor de paquets"
"text": "Instal·lar Node.js mitjançant gestor de paquets"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mitjançant un gestor de paquets

Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Tsuna-mi

I did a small suggestion, take a look please.

@Tsuna-mi
Copy link
Contributor Author

@fhemberger This also has no conflicts... if you can't merge it, tell me something

@fhemberger
Copy link
Contributor

@Tsuna-mi This one looks the same for me. Please go ahead and merge it. Thank you!

@Tsuna-mi Tsuna-mi merged commit 0f4ab92 into master Oct 22, 2018
@Tsuna-mi Tsuna-mi deleted the Tsuna-mi-sync-site-json-ca branch October 22, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants