-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial .browserslistrc file #2602
Conversation
Alright, I changed the patch to be defaults + IE >= 10, see https://browsersl.ist/?q=defaults%2C+Explorer+%3E%3D+10 This should be the safest approach since without a .browserslistrc file the defaults are used. |
Can we get a review about this? The solution I went with is as close as it gets to the current master. IE9 does not work due to This is the diff with IE9 added vs the current patch (which is defaults + IE>=10): https://gist.github.com/XhmikosR/0ffdac274b042e3e89f2c8c45d0943dd/revisions |
Using browserslist defaults along with IE >= 10.
BTW if we decide to sort of support IE9, we should tweak the scroll to top script to not use |
/ping @nodejs/website |
I think this is fine and can be revisited later if it turns out to be too restrictive. |
Is this used by any other tools besides the |
Currently no AFAICT, but it can be used by other tools. |
So, how about IE 9? |
Not sure if it matters much if this setup will be eventually replaced with https://github.com/nodejs/nodejs.dev/. Whatever browsers it's working with today is probably OK |
Well, IE9 isn't currently specified in master. But apart from the JS error due to |
@XhmikosR I think we can move forward with this as is right now and in a follow up PR get a solution to fix IE9 and update the support table. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SGTM. I'll leave #2464 open for discussion |
This is a very basic patch, mostly opened for discussion.
To visualize what's supported with this patch please check: https://browsersl.ist/?q=%3E%3D+0.2%25%2C+last+2+major+versions%2C+not+dead%2C+Android+%3E%3D+6%2C+Chrome+%3E%3D+45%2C+Edge+%3E%3D+12%2C+Explorer+%3E%3D+10%2C+Firefox+%3E%3D+38%2C+iOS+%3E%3D+9%2C+Safari+%3E%3D+9
and this is with the defaults: https://browsersl.ist/?q=defaults
Notes:
Firefox ESR
Refs #2464