migrating `ApiChanges` #5351

vasanth9 · 2023-05-03T12:59:26Z

Related #5309

created new branch and resolved all comments from #5344

…js#5178 feat(unit-test): introduce unit test

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.

…ooks (nodejs#5281)

Co-authored-by: Michael Esteban <mickel13@gmail.com>

chore: next lock to versin 13.2.0

Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com>

…dejs#5236) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com>

…mplates (nodejs#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

…ies (nodejs#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx

* chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries

fix(package.json) lint:fix missing slashes

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>

ovflowd · 2023-05-11T23:35:22Z

Could you run npm run test:storybook:snapshot to generate snapshot of your stories.

I did it , but it updated 4 snaps

So it does not create a new snapshot? What snapshot it does update? 🤔

AugustinMauroy · 2023-05-12T18:44:27Z

components/Api/ApiChanges/index.stories.tsx

+    changes: [
+      {
+        version: version,
+        'pr-url': 'https://test.com',


to have perfect mock

Suggested change

'pr-url': 'https://test.com',

'pr-url': 'https://github.com/nodejs/node/pulls',

* Migrate JsonLink component Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * Add storybook snap and robot icon Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * Remove IconContext provider Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> --------- Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

…s#5376) * refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: Add MUI Config and Theme Provider * added createTheme * refactor themeConfig * feat(theme): Fix linting and package-lock * feat(theme): Add emotion styled and emtion react --------- Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>

refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: build --------- Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>

* feat: create codebox component * feat: add pointer to copy button * feat: add shell support * feat: use code element instead of pre * chore: fix eslint issues * refactor: remove shell codebox * refactor: use react.fc type * refactor: remove duplicate encoding * refactor: use pre element for codebox * style: some eol * style: some eol * refactor: use pre element for codebox * chore: create inlinecode story * refactor: create inline code story type * chore: revert .browserslistrc * test: remove duplicated test * test: remove beginning space on code * refactor: setup userEvent on tests * refactor: remove useless async * test: manual mock isomorphic-dompurify * fix: some fixes * chore: create multi lang story * test: snapshot before and after switch lang * refactor: inline mock * refactor: use decorators * chore: split inlinecode component * feat: add selected lang state * refactor: add inlinecode decorator * refactor: remove duplicate classes * chore: revert .browserslistrc * test: fix tests * chore: wip * feat: use story component arg * style: stories * test: remove i18n from clipboard test * chore: migrate pagination component (nodejs#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * chore: add a proper decorated component * refactor: decorated inline code * Chore(node feat) (nodejs#5338) Co-authored-by: Claudio Wunder <cwunder@gnome.org> * (website redesign) Feat(shellbox): migration (nodejs#5234) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * fix(i18n): translation key (nodejs#5347) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: add hover states * chore: fix rebase leftovers * chore: update snapshots * chore: install @types/prismjs * Update index.stories.tsx Signed-off-by: Claudio Wunder <cwunder@gnome.org> * chore: remove duplicate snapshots * chore: remove duplicate snapshot --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com>

* Migrate: Source-link * Fix: JSON key moved to the end of the file * Test: Storybook snapshot test --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: introduce built-in next.js exports and updated scripts and configs (nodejs#5384) * chore: updated gitignore and rmeoved robots.txt * chore: updated next-sitemap config * chore: next-config refactored options and export support * chore: updated imports to node: prefix * chore: updated contributing guidelines * chore: updated scripts * chore: updated next-sitemap * chore: added missing props * fix: github-pages * chore: remove unused package * fix(storybook): update packages (nodejs#5386) --------- Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>

vercel · 2023-05-20T05:43:04Z

Someone is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

vasanth9 · 2023-05-20T06:31:26Z

Could you run npm run test:storybook:snapshot to generate snapshot of your stories.

I did it , but it updated 4 snaps

So it does not create a new snapshot? What snapshot it does update? thinking

Hey I ran it again, now it created the new snapshot for ApiChanges

ovflowd · 2023-05-24T13:38:45Z

FYI: We deleted the major/website-redesign branch to simplify our release and rollout process. Please feel free to recreate this PR or reopen it with the main branch as a target.

Thank you, and we apologise for the inconvenience!

vasanth9 · 2023-05-24T14:04:59Z

Ok

AugustinMauroy and others added 30 commits April 15, 2023 10:17

feat(unit-test): introduce unit test on website redesign branch (node…

bd8a46e

…js#5178 feat(unit-test): introduce unit test

chore(redesign): added new folders for new layouts and new pages

80039d3

chore(minor): just a tiny design nitpick

cdbc4b4

chore: set up storybook (nodejs#5191) (nodejs#5214)

df79868

feat(ignore): add storyBook (nodejs#5229)

ecbec61

chore: set up testing-library jest extend (nodejs#5231)

a2a4bd8

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

chore(dependencies): updated dependencies

67999b6

feat: create section title component (nodejs#5237)

48d6c91

Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

📎 chore(migration): migrate banner component (nodejs#5233)

6ce6923

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

feat: migrate AnimatedPlaceholder component (nodejs#5238

f9d9765

Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.

feat: create article alert component (nodejs#5243)

9311785

chore(dependencies): updated dependencies

06ce22b

fix: formatted file

386a458

chore: updated deps

0240b9b

feat: migrate blockquote component (nodejs#5259)

ffa9a3e

feat(stylelint,storybook): fixed styleling misconfig and fixed storyb…

390c2da

…ooks (nodejs#5281)

feat: create article data tag component (nodejs#5280)

e121b83

feat: migrate AuthorList component and add story 🎉 (nodejs#5277)

d7a154d

Co-authored-by: Michael Esteban <mickel13@gmail.com>

chore: lock nextjs to 13.2.0 (nodejs#5301

620f58e

chore: next lock to versin 13.2.0

feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (no…

bb46dfe

…dejs#5236) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com>

chore: updated contributing guidelines, eslint rules and storybook te…

bfcabb9

…mplates (nodejs#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

chore: contributing quick fix of example

f6dc39f

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

chore: story guide and react spreading

2eba819

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

chore: remove base styles from old styling

86b60f3

fix(package.json) Lint command is missing slashes (nodejs#5321

5891807

fix(package.json) lint:fix missing slashes

moved DataTag to components/Api (nodejs#5317)

ca8b5ab

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>

hot-fix: dependency updates and fix dev runtime

c2aeeaa

AugustinMauroy reviewed May 12, 2023

View reviewed changes

AugustinMauroy and others added 13 commits May 14, 2023 09:10

feat(stability): migrate component (nodejs#5339)

a51457d

refactor(delete): duplicate test file (nodejs#5377)

a8fa762

refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <cwunder@gnome.org>

Merge branch 'main' into major/website-redesign

51128c3

Migrate: Source-link (nodejs#5364)

c254c60

* Migrate: Source-link * Fix: JSON key moved to the end of the file * Test: Storybook snapshot test --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

Merge branch 'main' into major/website-redesign

d4a2c1f

chore: minor story updates (nodejs#5387)

8105e19

Merge branch 'major/website-redesign' into feature-ApiChanges

94c3129

vercel bot temporarily deployed to Preview – nodejs-org-stories May 20, 2023 05:44 Inactive

to have perfect mock

6a986bd

vercel bot temporarily deployed to Preview – nodejs-org-stories May 20, 2023 05:45 Inactive

reverted some unwanted code

25aecc1

vercel bot temporarily deployed to Preview – nodejs-org-stories May 20, 2023 05:53 Inactive

added snapshot

b4f0a4a

vercel bot temporarily deployed to Preview – nodejs-org-stories May 20, 2023 06:30 Inactive

ovflowd force-pushed the major/website-redesign branch from cb8c95e to 9243764 Compare May 24, 2023 13:33

ovflowd deleted the branch nodejs:major/website-redesign May 24, 2023 13:37

ovflowd closed this May 24, 2023

vasanth9 mentioned this pull request Jun 2, 2023

Feat(api changes) #5417

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrating `ApiChanges` #5351

migrating `ApiChanges` #5351

vasanth9 commented May 3, 2023 •

edited

ovflowd commented May 11, 2023

AugustinMauroy May 12, 2023

vercel bot commented May 20, 2023

vasanth9 commented May 20, 2023 •

edited

ovflowd commented May 24, 2023

vasanth9 commented May 24, 2023

	'pr-url': 'https://test.com',
	'pr-url': 'https://github.com/nodejs/node/pulls',

migrating ApiChanges #5351

migrating ApiChanges #5351

Conversation

vasanth9 commented May 3, 2023 • edited

ovflowd commented May 11, 2023

AugustinMauroy May 12, 2023

Choose a reason for hiding this comment

vercel bot commented May 20, 2023

vasanth9 commented May 20, 2023 • edited

ovflowd commented May 24, 2023

vasanth9 commented May 24, 2023

migrating `ApiChanges` #5351

migrating `ApiChanges` #5351

vasanth9 commented May 3, 2023 •

edited

vasanth9 commented May 20, 2023 •

edited