-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CrossLink component #5781
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marked it as draft because there are still some things that I want to check/think first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work ! Don't forget to give the box a maximum size
910e729
to
c57256e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last thing for me is the background, you should try to make it transparent. Because on a dark theme it's white whereas in the figma the background is black. I'm not sure that's clear but I hope you've understood 😁.
I dont think the bg should be transparent. Should be white. |
on figma the background of box is same of app background so it's should be transparent. |
That's an overstatement. The Component Figma's CSS properties definitely declares a white background. This should not be transparent. First, if we add this to a non-white background we would already be non-compliant with the theme, same on dark mode. |
c57256e
to
a120bca
Compare
Addressing @AugustinMauroy comments here
Actually I am not sure what "maximum size" you're talking about. If you're talking about the If you're talking about the preview in Storybook, I followed the 305px described in the Figma to demonstrate that the text truncation works.
As Claudio has described, we have color schemes for both light and dark mode. It's better to state what background color is used for each component as per the Figma. So there are no surprises when we are using the components later. |
a6092f8
to
f9434bb
Compare
FYI @HinataKah0 that we moved to PostCSS, so you need to rename the file from |
f9434bb
to
0a7efe3
Compare
0a7efe3
to
07b9e30
Compare
Signed-off-by: Claudio W <cwunder@gnome.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're ready! LGTM! Thank you, @HinataKah0 !!
Description
Implement new
CrossLink
component and Storybook's story as specified in the Figma.Validation
Related Issues
Fixes #5761
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.