Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: separate constants and introduce extra classes per theme #5875

Merged
merged 5 commits into from
Sep 23, 2023
Merged

meta: separate constants and introduce extra classes per theme #5875

merged 5 commits into from
Sep 23, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 22, 2023

This PR introduces extra class names to be used within Storybook stories to "simulate" the text colors and background colors that would apply on the actual Website (such as a dark theme with a dark background).

This PR also extracts these extra class names into a dedicated file.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Sep 22, 2023
@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 10:23pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Sep 22, 2023

cc @nodejs/nodejs-website requesting fast-tracking :)

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 4.627s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@ovflowd ovflowd mentioned this pull request Sep 22, 2023
Merged
5 tasks
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 22, 2023
mikeesto
mikeesto approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd ovflowd added this pull request to the merge queue Sep 23, 2023
@ovflowd ovflowd removed this pull request from the merge queue due to a manual request Sep 23, 2023
@ovflowd ovflowd merged commit a3e0b04 into main Sep 23, 2023
14 checks passed
@ovflowd ovflowd deleted the meta/extra-storybook-classes-by-theme branch September 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeesto mikeesto mikeesto approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovflowd @mikeesto