-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Working Groups page. #623
Conversation
|
||
The Docker working group's purpose is to build, maintain, and improve official | ||
Docker images. | ||
Docker images for the `Node.js` project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is Node.js formatted this way here, but not in, say, line 137?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question...? That'll be something to take up with the CTC's version of the info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright :)
overall good job! 👍 should we link to the page where the process of creating a working group is explained now, or later when it gets actually created? |
My opinion is that the detail in the |
I think the section on the Inclusivity WG reads well, but I notice that there is quite a bit of information about that WG, while the others only have their name listed. Was this intentional? If we are going to keep the other WG listed with just there name, I would recommend at least removing the "Responsibilities" section of the Inclusivity WG to make the section shorter, if not remove all of the info all together and just list the name like the others. However, an argument could be made that we should add similar info for the other working groups too and normalize info that way :) |
Its responsibilites are: | ||
* Foster a welcoming environment that ensures participants are valued and can | ||
feel confident contributing or joining discussions, regardless of any aspect of | ||
their identity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the "including but not limited to" section was left off. The list is an important part of this statement. If we are going to list the responsibilities section then I think it should be listed in full, not summarized.
@nebrius The info for Inclusivity was just taken from: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
I don't see that in that document...? Help me find what you're looking at. I don't want to leave anything out!
All of the other groups have a Responsibilities section. |
Iiiiinteresting. https://github.com/nodejs/inclusivity/#list-of-responsibilities <= that is the definitive document. I submitted nodejs/TSC#86 to update the TSC copy.
Ugh, reading comprehension fail on my part, you're right. |
@nebrius I copied in your Inclusivity changes from nodejs/TSC#86 |
LGTM, thanks for the updates :) |
The information was just a copy+paste from:
https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md and
https://github.com/nodejs/node/blob/master/WORKING_GROUPS.md
...and then some more detailed sections were deleted (i.e.: how to create a Working Group) since this is going in the
about
section of the main website and those levels of details are better left in GitHub.The focus is to update this info only. If you see errors or want to make suggestions that exist in both copies, I would rather do that in different PRs on both repos to keep this PR simple.
This supersedes #622