-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Break long words only in blog posts #6944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Camina <67751672+caminad@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Camina <67751672+caminad@users.noreply.github.com>
bmuenzenmeyer
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good improvement - thanks for your contribution!
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
ovflowd
reviewed
Jul 31, 2024
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
word-break: break-all;
on narrow viewports only, tooverflow-wrap: anywhere;
on all viewport sizes.word-break: break-word;
also works, but is deprecated (see note in the spec.) I could not find a suitable Tailwind utility; break-words producesoverflow-wrap: break-word;
, which does not prevent an overflow.Validation
Navigate to
/en/blog/vulnerability/april-2024-security-releases#assertion-failed-in-nodehttp2http2sessionhttp2session-leads-to-http2-server-crash-cve-2024-27983---high
and check that all words are no longer broken. The page should not scroll horizontally.main
)Related Issues
Fixes #6943, related to #6711, related to #6721.
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.