Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PUBLISH-GUIDELINES.md from draft #489

Merged
merged 6 commits into from
Nov 23, 2021

Conversation

hutchgrant
Copy link
Contributor

No description provided.

@hutchgrant hutchgrant changed the title Promote PUBLISH+GUIDELINES.md from draft Promote PUBLISH-GUIDELINES.md from draft Oct 28, 2021
Copy link
Contributor

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i'm catching up on this doc now to refresh myself, but assuming all goes well, only other change needed here would be to remove the (draft) label for this doc in the Table of Contents.

@thescientist13 thescientist13 linked an issue Oct 28, 2021 that may be closed by this pull request
@thescientist13 thescientist13 added article Need to spread this information package-maintenance-agenda Agenda items for package-maintenance team labels Oct 28, 2021
docs/README.md Outdated Show resolved Hide resolved
@thescientist13 thescientist13 added the hacktoberfest-accepted Tag as eligible to get hacktoberfest credit even if it has not laneded yet. label Oct 28, 2021
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thescientist13
Copy link
Contributor

@hutchgrant
Just needs a resolution for a merge conflict then it is good to merge 👍

@thescientist13 thescientist13 merged commit e4714eb into nodejs:main Nov 23, 2021
@thescientist13 thescientist13 removed the package-maintenance-agenda Agenda items for package-maintenance team label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
article Need to spread this information hacktoberfest-accepted Tag as eligible to get hacktoberfest credit even if it has not laneded yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] publishing guidelines (draft)
5 participants