Bring string_decoder into the foundation

[mcollina]

Very recently a bug was reported to string_decoder, and @rvagg forwarded it to me. (a test is failing in node 4+).

That module uses a very similar machinery to readable-stream to keep it in sync with latest Node.js. I'm in the process of updating that as well to the latest node.js.

Speaking with @rvagg, I think it might be a good idea to move it under the nodejs github organization, and we keep that in sync together with readable-stream.

Do you all agree it's a good idea?

[calvinmetcalf]

is this the one browserify uses ?

[mcollina]

yes, https://github.com/substack/node-browserify/blob/master/package.json#L60

[mcollina]

We also depend on that: https://github.com/nodejs/readable-stream/blob/master/package.json#L12

[calvinmetcalf]

we also rely on process, that might be a good one to move over to the node umbrella too, that being said it's very different from string_decoder or this as it's a shim that attempts to simulate node behavior

[mcollina]

@calvinmetcalf I think string_decoder is lifted from core, and as such I think it should be under the foundation.

process is very different, I would not touch that atm.

[mcollina]

I've tagged this @nodejs/ctc, as I think it's the best course of action.

[joshgav]

This should be reviewed by the TSC too, added label.

[mcollina]

@nodejs/ctc has no problem in this if @nodejs/tsc is ok with it.

[mhdawson]

This looks familiar was there another issue where people were asked to weigh in or was that a different package ?

[joshgav]

@mhdawson

ref: nodejs/TSC#260

[mhdawson]

@joshgav thanks, wanted to make sure I had chimed into the conversation.

[mcollina]

This has been done, and we can close this.