Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interceptors: move throwOnError to interceptor #3275

Closed
Tracked by #2835
metcoder95 opened this issue May 19, 2024 · 6 comments
Closed
Tracked by #2835

interceptors: move throwOnError to interceptor #3275

metcoder95 opened this issue May 19, 2024 · 6 comments
Labels
good first issue Good for newcomers interceptors Pull requests or issues related to Dispatcher Interceptors

Comments

@metcoder95
Copy link
Member

No description provided.

@metcoder95 metcoder95 mentioned this issue May 19, 2024
Closed
13 tasks
@metcoder95 metcoder95 added good first issue Good for newcomers interceptors Pull requests or issues related to Dispatcher Interceptors labels May 19, 2024
@metcoder95 metcoder95 changed the title move throwOnError to interceptor interceptors: move throwOnError to interceptor May 19, 2024
@mcollina
Copy link
Member

I'm not sure we can, but it would be cool to do

@ronag
Copy link
Member

ronag commented May 23, 2024

Done here: https://github.com/nxtedition/nxt-undici/blob/main/lib/interceptor/response-error.js if someone wants to port it.

@metcoder95
Copy link
Member Author

Closed by #3331

@ronag ronag reopened this Jul 14, 2024
@ronag
Copy link
Member

ronag commented Jul 14, 2024

We are still not actually using the interceptor

@metcoder95
Copy link
Member Author

True 🤦‍♂️
Too preemptive

@metcoder95
Copy link
Member Author

Safe to close now with #3451? 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers interceptors Pull requests or issues related to Dispatcher Interceptors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @ronag @metcoder95