Canary broken on some platforms

[targos]

Trying to build V8 5.9.53
CI run: https://ci.nodejs.org/job/node-test-commit/8510/

Output:

../deps/v8/src/base/platform/platform-posix.cc: In member function 'virtual const char* v8::base::PosixTimezoneCache::LocalTimezone(double)':
../deps/v8/src/base/platform/platform-posix.cc:390:17: error: 'struct std::tm' has no member named 'tm_zone'
   if (!t || !t->tm_zone) return "";
                 ^
../deps/v8/src/base/platform/platform-posix.cc:391:13: error: 'struct std::tm' has no member named 'tm_zone'
   return t->tm_zone;
             ^
../deps/v8/src/base/platform/platform-posix.cc: In member function 'virtual double v8::base::PosixTimezoneCache::LocalTimeOffset()':
../deps/v8/src/base/platform/platform-posix.cc:399:33: error: 'struct std::tm' has no member named 'tm_gmtoff'
   return static_cast<double>(t->tm_gmtoff * msPerSecond -
                                 ^
../deps/v8/src/base/platform/platform-posix.cc: In member function 'virtual const char* v8::base::PosixTimezoneCache::LocalTimezone(double)':
../deps/v8/src/base/platform/platform-posix.cc:392:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../deps/v8/src/base/platform/platform-posix.cc: In member function 'virtual double v8::base::PosixTimezoneCache::LocalTimeOffset()':
../deps/v8/src/base/platform/platform-posix.cc:401:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
deps/v8/src/v8_libbase.target.mk:103: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/v8_libbase/deps/v8/src/base/platform/platform-posix.o' failed
make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/v8_libbase/deps/v8/src/base/platform/platform-posix.o] Error 1

Refs:

• https://codereview.chromium.org/2731463003
• https://bugs.chromium.org/p/v8/issues/detail?id=6031

/cc @nodejs/platform-smartos @nodejs/platform-aix

[misterdjules]

Someone from @nodejs/platform-smartos will take a look next Monday at the latest. Thanks for the heads up!

[jbajwa]

The aix issue is being looked at https://codereview.chromium.org/2740353002/ . Should be fixed soon.

[sampsongao]

The patch is landed. Should be fixed now.

[misterdjules]

@geek is currently looking at the fix in https://codereview.chromium.org/2740353002/ to make sure it builds and works on SmartOS. Thanks for fixing it in the first place!

[geek]

I confirmed that the canary branch builds and works on SmartOS with the changes in https://codereview.chromium.org/2740353002/diff/20001/src/base/platform/platform-posix.cc

[misterdjules]

Thank you @geek!

[targos]

Super, thank you!