Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display numbers in unit 数字 十一到一百 horizontally #437

Closed
1 task done
toshify opened this issue Dec 11, 2023 · 0 comments · Fixed by #442
Closed
1 task done

fix: Display numbers in unit 数字 十一到一百 horizontally #437

toshify opened this issue Dec 11, 2023 · 0 comments · Fixed by #442
Assignees
@toshify
Labels
bug Something isn't working

Comments

@toshify
Copy link
Collaborator

toshify commented Dec 11, 2023

Describe the bug

When using the review system (tap the "eye" in the lesson menu), numbers with multiple digits are displayed one above the other, but should be displayed side by side, i.e.
60
rather than
6
0

Steps to reproduce

  1. Go to the main menu
  2. Click on the left button with an "eye" icon under the 数字 十一到一百 text
  3. Tap the green arrow at the bottom to progress until you see "6 0"
  4. Observe the incorrect formatting of 6 above the 0, and not side by side.

Expected behavior

6 and 0 should be displayed side by side

Screenshots

2

Environment

  • Device: Both phone and pc
  • OS: Windows 11, iOS17.1.2
  • Browser chrome, safari
@toshify toshify added the bug Something isn't working label Dec 11, 2023
@toshify toshify self-assigned this Dec 11, 2023
toshify added a commit to toshify/seedlingo that referenced this issue Dec 11, 2023
@toshify
fix: Display consecutive icons in review horizontaly
18a2159 
Because we use icons to represent digits in numbers,
and combine multiple icons to represent large numbers, like 65,

this commit will:
- display multiple icons on the same line until the line owerflows,
  rather than vertically with one icon per line

Resolves nodepa#437

**Certification**
- [X] I certify that <!-- Check the box to certify: [X] -->
- I have read the [contributing guidelines](
  https://github.com/nodepa/seedling/blob/main/.github/CONTRIBUTING.md)
- I license these contributions to the public under Seedling's
  [LICENSE](https://github.com/nodepa/seedling/blob/main/LICENSE.md)
  and have the rights to do so.

Signed-off-by: toshify <4579559+toshify@users.noreply.github.com>
@toshify toshify mentioned this issue Dec 11, 2023
Merged
1 task
toshify added a commit that referenced this issue Dec 12, 2023
@toshify
fix: Display consecutive icons in review horizontaly (#442)
125baa2 
Because we use icons to represent digits in numbers,
and combine multiple icons to represent large numbers, like 65,

this commit will:
- display multiple icons on the same line until the line owerflows,
  rather than vertically with one icon per line

Resolves #437

**Certification**
- [X] I certify that <!-- Check the box to certify: [X] -->
- I have read the [contributing guidelines](
  https://github.com/nodepa/seedling/blob/main/.github/CONTRIBUTING.md)
- I license these contributions to the public under Seedling's
  [LICENSE](https://github.com/nodepa/seedling/blob/main/LICENSE.md)
  and have the rights to do so.

Signed-off-by: toshify <4579559+toshify@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toshify toshify

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Display consecutive icons in review horizontaly toshify/seedlingo
1 participant
@toshify