Skip to content

Commit

Permalink
fix: Display consecutive icons in review horizontaly (#442)
Browse files Browse the repository at this point in the history
Because we use icons to represent digits in numbers,
and combine multiple icons to represent large numbers, like 65,

this commit will:
- display multiple icons on the same line until the line owerflows,
  rather than vertically with one icon per line

Resolves #437

**Certification**
- [X] I certify that <!-- Check the box to certify: [X] -->
- I have read the [contributing guidelines](
  https://github.com/nodepa/seedling/blob/main/.github/CONTRIBUTING.md)
- I license these contributions to the public under Seedling's
  [LICENSE](https://github.com/nodepa/seedling/blob/main/LICENSE.md)
  and have the rights to do so.

Signed-off-by: toshify <4579559+toshify@users.noreply.github.com>
  • Loading branch information
toshify authored Dec 12, 2023
1 parent f427525 commit 125baa2
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions app/src/views/ReviewSession.vue
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,15 @@ onMounted(() => {
v-else-if="word.symbol && word.symbol.length > 0"
style="display: flex; justify-content: center; align-items: center"
>
<ion-icon
v-for="(icon, iconIndex) in word.symbol"
:key="iconIndex"
data-test="review-icon"
:icon="Content.getIcon(icon)"
style="font-size: 4rem"
/>
<span>
<ion-icon
v-for="(icon, iconIndex) in word.symbol"
:key="iconIndex"
data-test="review-icon"
:icon="Content.getIcon(icon)"
style="font-size: 4rem"
/>
</span>
</ion-card-header>
<ion-card-content style="display: flex; flex: 1">
<ExerciseButton
Expand Down

0 comments on commit 125baa2

Please sign in to comment.