Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong PPID is sent #2

Open
skadisch opened this issue Dec 24, 2021 · 0 comments
Open

Wrong PPID is sent #2

skadisch opened this issue Dec 24, 2021 · 0 comments

Comments

@skadisch
Copy link

In this line options.streamId is accessed, but it doesn't exist. object.stream_id (local variable streamId) would exist, but the way I see it, it would be wrong as well. PPID means Payload Protocol Identifier and should specify the type of the payload in the packet. For example WebRTC uses 51 for Strings and 53 for binary data.

An easy solution would be to require a options.ppid to be given to the Association.send() method. The Socket class already has the Socket.ppid property, which it could pass down to the association.

Yet, it raises the question, if one should be capable of specifying the ppid value on a per packet basis. Then the Duplex API is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant