Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Error messages for failed downloads #720

Open
hasezoey opened this issue Dec 5, 2022 · 3 comments
Open

Update Error messages for failed downloads #720

hasezoey opened this issue Dec 5, 2022 · 3 comments
Labels
enhancement

Comments

@hasezoey
Copy link
Member

hasezoey commented Dec 5, 2022

Currently the Errors for failed downloads are not very helpful, like:

https://github.com/nodkz/mongodb-memory-server/blob/2d46099b857421d2fd7737a4328ed9146cce2a90/packages/mongodb-memory-server-core/src/util/MongoBinaryDownload.ts#L434

it only says that the code is not 200, but not which code it actually was.
there are also some other errors thrown for failed downloaded which should also be handled better
hasezoey added a commit that referenced this issue Jan 6, 2023
@hasezoey
style(MongoBinaryDownload): add status code to "status is not 200" error
ad304ee 
re #720
@SaptatirthaChoudhury

This comment was marked as off-topic.

Sign in to view
@hasezoey

This comment was marked as off-topic.

Sign in to view
@SaptatirthaChoudhury

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hasezoey @SaptatirthaChoudhury