Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add solon to TechEmpower benchmarks? #80

Closed
pmg1991 opened this issue Dec 9, 2022 · 24 comments
Closed

Should we add solon to TechEmpower benchmarks? #80

pmg1991 opened this issue Dec 9, 2022 · 24 comments

Comments

@pmg1991
Copy link
Contributor

pmg1991 commented Dec 9, 2022

No description provided.

@noear
Copy link
Member

noear commented Dec 9, 2022

我觉得可以加:)。。。不过,我英文不好,不是中文的网站都不大熟。

@noear
Copy link
Member

noear commented Dec 9, 2022

帮忙多介绍些用户。希望今年,能让 star 加到 1000 个:)

@pmg1991
Copy link
Contributor Author

pmg1991 commented Dec 9, 2022

Create one benchmark comparing Quarkus, Micronaut, Spring , Helidon and Solon, Both performance and deployment size. Then share link to Hacker News. You'll get the expected exposure .

@noear
Copy link
Member

noear commented Dec 9, 2022

https://github.com/noear/helloworld_wrk_test

我之前建过这个测试项目。你看看怎么样?

@noear
Copy link
Member

noear commented Dec 9, 2022

你可以帮忙。。。加上 Quarkus, Micronaut, Helidon 的测试代码吗?

@pmg1991
Copy link
Contributor Author

pmg1991 commented Dec 9, 2022

你可以帮忙。。。加上 Quarkus, Micronaut, Helidon 的测试代码吗?

Yes I will

@noear
Copy link
Member

noear commented Feb 2, 2023

朋友。。。Solon 2.0 发布了,帮忙宣传一下:)

@pmg1991
Copy link
Contributor Author

pmg1991 commented Feb 9, 2023

I've crated the initial code here https://github.com/pmg1991/FrameworkBenchmarks/tree/master/frameworks/Java/solon

Can you check it, If every thing looks ok I will push this to original Techem benchmark.

Also can you help to setup orm for postgres?

@noear
Copy link
Member

noear commented Feb 9, 2023

非常感觉,我晚上去测试一下:)

@noear
Copy link
Member

noear commented Feb 9, 2023

正常运行没问题,但用 wrk 测的时候好像有问题。。。我明天再好好研究一下

@pmg1991
Copy link
Contributor Author

pmg1991 commented Feb 11, 2023

When compared to smart-http , Solon seems a little slower ( 16K vs 14K request per sec on my machine) Can you check if it can be optimized?

One place I found is https://github.com/noear/solon/blob/6e0f6f8f9591ec3408c2edfcde5291835adb1ed8/_solon_boot/solon.boot.smarthttp/src/main/java/org/noear/solon/boot/smarthttp/http/SmartHttpContextHandler.java#L51 , a new SmartHttpContext is created for every request can this be pooled via thread local?

@noear
Copy link
Member

noear commented Feb 11, 2023

添加应用配置:“server.http.ioBound=false”。程序在 cpu 密集型 和 io 密集型下,线程配置不同。。。要跑分高,需要加:“server.http.ioBound=false”。。。。我已经在你的代码仓库上,提交了 pr。。。你再看一下

@pmg1991
Copy link
Contributor Author

pmg1991 commented Feb 11, 2023

It was faster :) , Raised Pull to Upstream.

@noear
Copy link
Member

noear commented Feb 11, 2023

我感觉 solon 应该像 springboot 的风格去写测试代码(因为 solon 对标的是 springboot)。我改改代码再提交个 pr

@noear
Copy link
Member

noear commented Feb 12, 2023

pr 已提交

@pmg1991
Copy link
Contributor Author

pmg1991 commented Feb 12, 2023

Categories left are : Single Db query, Multiple Db Queries, Update Db Query, Template Rendering

@noear
Copy link
Member

noear commented Feb 12, 2023

还需要添加数据库查询之类的测试代码吗?

@pmg1991
Copy link
Contributor Author

pmg1991 commented Feb 13, 2023

https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#general-test-requirements

We have only implemented 2 Test types( Json and Plaintext), 5 still left, We have to implement them using the above guide lines.

@noear
Copy link
Member

noear commented Feb 13, 2023

好的。

@pmg1991
Copy link
Contributor Author

pmg1991 commented Feb 15, 2023

I'll work on the rest of the categories over the weekend.

@noear
Copy link
Member

noear commented Feb 15, 2023

https://solon.noear.org/start/

今天做了个 Solon Initializr (Preview)

@pmg1991
Copy link
Contributor Author

pmg1991 commented Mar 16, 2023

@noear
Copy link
Member

noear commented Mar 16, 2023

感觉还是有点慢。理论上,应该跟 smart-servlet 差不多。

@noear
Copy link
Member

noear commented Mar 16, 2023

我去看看 smart-servlet 在配置上,是不是有什么优化;)

@noear noear closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants