Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong lesion labelling #21

Closed
1-w opened this issue Sep 25, 2023 · 1 comment
Closed

Wrong lesion labelling #21

1-w opened this issue Sep 25, 2023 · 1 comment
Assignees
@ravnoor
Labels
bug Something isn't working

Comments

@1-w
Copy link

1-w commented Sep 25, 2023

https://github.com/NOEL-MNI/deepFCD/blob/69ae43e7b180d4f1c54d70c0d5d5be6c98f50b8c/app/utils/post_processor.py#L59C1-L59C57

This should be = label_list[l] , instead of ] = num_elements_by_lesion[l].astype(np.int) right?
@ravnoor
Copy link
Contributor

ravnoor commented Sep 25, 2023

That seems about right. num_elements_by_lesion[l].astype(np.int) outputs the size (voxel count) of the putative lesion instead of the sequential label number. I'll push the change in a day or two. Thanks for reporting!

If you're looking to post-process the outputs for reporting, I might suggest looking at utils/reporting.py. It's more intuitive and straightforward.

@ravnoor ravnoor self-assigned this Sep 25, 2023
@ravnoor ravnoor added the bug Something isn't working label Sep 25, 2023
ravnoor added a commit that referenced this issue Sep 27, 2023
@ravnoor
fix lesion labelling bug (gh-21)
21dac51
@ravnoor ravnoor closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravnoor ravnoor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ravnoor @1-w