Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide error and ready events #115

Closed
wants to merge 3 commits into from
Closed

Provide error and ready events #115

wants to merge 3 commits into from

Conversation

bergie
Copy link
Member

@bergie bergie commented Jul 28, 2018

This makes defaultGraph initialization asynchronous so that callers can handle its results via events.

Also adds events to the base runtime class:

  • ready: if defaultGraph is supplied, emitted when that network is ready. Otherwise emitted after runtime is ready
  • error: if network can't be created for the defaultGraph

Fixes noflo/noflo#603

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 41.709% when pulling 751fb36 on error_port_test into 07a4954 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception when graph contains error
2 participants