Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover is not responsive #62

Open
NeevShah opened this issue Jan 8, 2015 · 4 comments
Open

Popover is not responsive #62

NeevShah opened this issue Jan 8, 2015 · 4 comments

Comments

@NeevShah
Copy link

NeevShah commented Jan 8, 2015

First of all its a great library to use. However I'm facing a problem. My application is supported in any resolutions. But popover doesn't look good when I use it in mobile devices. It don't stick to that element properly. Am I doing something wrong or popover is not responsive?

@ianwalter
Copy link
Collaborator

Are you seeing the same behavior on the example page?

@httpete
Copy link

httpete commented Jan 9, 2015

The biggest issue is edge detection. If the popover pops outside the viewport, it needs to dynamically shift so that the contents are inside.

@ianwalter
Copy link
Collaborator

I see. We had to do this for ng-context-menu as well. We can probably use a similar implementation (comparing against the document dimensions and subtracting the difference from the popover's position): https://github.com/ianwalter/ng-context-menu/blob/development/src/ng-context-menu.js#L35-L58

@NeevShah
Copy link
Author

Sorry for late replay .. Yes example page has same issue. It pops out of view port. @httpete thanks for elaborating my question. And great work for contextmenu 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants