Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): Fix mem2reg pass not always removing unused stores #1677

Merged
merged 3 commits into from
Jun 14, 2023
Merged

fix(ssa refactor): Fix mem2reg pass not always removing unused stores #1677

merged 3 commits into from
Jun 14, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 13, 2023

Description

Problem*

Resolves

Summary*

This is a somewhat rolled back version of #1654. This PR:

  1. Simplifies mem2reg a bit by removing address offset handling which no longer exists
  2. Fixes a bug where stores weren't always removed since basic_blocks_iter may iterate over blocks that are not reachable, causing the block count check to be off.

Example

Before:

After:

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

joss-aztec
joss-aztec approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joss-aztec joss-aztec added this pull request to the merge queue Jun 14, 2023
@joss-aztec joss-aztec mentioned this pull request Jun 14, 2023
Closed
Merged via the queue into master with commit 8310544 Jun 14, 2023
@joss-aztec joss-aztec deleted the jf/mem2reg branch June 14, 2023 08:44
@kevaundray kevaundray mentioned this pull request Jun 14, 2023
Closed
@joss-aztec joss-aztec mentioned this pull request Jun 14, 2023
Closed
5 tasks
@kevaundray kevaundray mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joss-aztec joss-aztec joss-aztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfecher @joss-aztec