Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver panics on unresolved dependency #1718

Closed
phated opened this issue Jun 15, 2023 · 0 comments · Fixed by #1719
Closed

Driver panics on unresolved dependency #1718

phated opened this issue Jun 15, 2023 · 0 comments · Fixed by #1719
Assignees
Labels
bug Something isn't working

Comments

@phated
Copy link
Contributor

phated commented Jun 15, 2023

Aim

The noirc_driver has primarily been used in nargo_cli where we attach a panic handler to capture failures; however, we are starting to use noirc_driver in the LSP where we shouldn't be having panics happen.

One such panic is when a dependency cannot be resolved. This should instead return an error diagnostic.

Expected Behavior

The driver should not panic and should instead return an error diagnostic for unresolved dependencies.

Bug

Driver panics, not diagnostics returned.

To Reproduce

  1. Set up the LSP
  2. Save a file with a dep that doesn't exist
  3. LSP will crash

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the bug Something isn't working label Jun 15, 2023
@phated phated self-assigned this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant