You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The noirc_driver has primarily been used in nargo_cli where we attach a panic handler to capture failures; however, we are starting to use noirc_driver in the LSP where we shouldn't be having panics happen.
One such panic is when a dependency cannot be resolved. This should instead return an error diagnostic.
Expected Behavior
The driver should not panic and should instead return an error diagnostic for unresolved dependencies.
Bug
Driver panics, not diagnostics returned.
To Reproduce
Set up the LSP
Save a file with a dep that doesn't exist
LSP will crash
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Aim
The
noirc_driver
has primarily been used innargo_cli
where we attach a panic handler to capture failures; however, we are starting to usenoirc_driver
in the LSP where we shouldn't be having panics happen.One such panic is when a dependency cannot be resolved. This should instead return an error diagnostic.
Expected Behavior
The driver should not panic and should instead return an error diagnostic for unresolved dependencies.
Bug
Driver panics, not diagnostics returned.
To Reproduce
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered: